Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree-wide: autorename gnome packages to use dashes #35519

Merged
merged 1 commit into from Feb 25, 2018
Merged

tree-wide: autorename gnome packages to use dashes #35519

merged 1 commit into from Feb 25, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Feb 25, 2018 •
edited

Motivation for this change

Closes: #32804

The only rebuild should be plasma-nm, where patch has been modified.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar added this to the 18.03 milestone Feb 25, 2018
@jtojnar
Copy link
Contributor Author

jtojnar commented Feb 25, 2018

If someone wants to review it here on GitHub:

document.querySelectorAll('.load-diff-button').forEach(e => e.click())

@jtojnar
Copy link
Contributor Author

jtojnar commented Feb 25, 2018 •
edited

I checked it once more and did not found any issues except for missing gnome-2 aliases, which I have now added.

@jtojnar jtojnar requested review from fpletz and vcunat and removed request for peti, ttuegel, rycee and FRidh February 25, 2018 04:26
@bjornfor
Copy link
Contributor

Great stuff! May I suggest to squash the last fixup commit, as to not break git bisect?

@jtojnar
Copy link
Contributor Author

jtojnar commented Feb 25, 2018

@bjornfor I would leave it for just before the merge. It is useful if I need to re-generate it.

@jtojnar jtojnar merged commit a31d98f into NixOS:master Feb 25, 2018
@jtojnar jtojnar deleted the gnome-normalisation branch February 25, 2018 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
6.topic: emacs 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: nixos 6.topic: python 6.topic: qt/kde 6.topic: rust 6.topic: steam 6.topic: xfce The Xfce Desktop Environment 8.has: clean-up 8.has: documentation 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
18.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @bjornfor @GrahamcOfBorg