Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxterminal: switch to using GTK3 #35531

Merged
merged 1 commit into from Feb 25, 2018
Merged

lxterminal: switch to using GTK3 #35531

merged 1 commit into from Feb 25, 2018

Conversation

velovix
Copy link
Contributor

@velovix velovix commented Feb 25, 2018

Motivation for this change

The version of VTE that uses GTK2 is not maintained, so using lxterminal with GTK2 means dealing with a lot of bugs that have already been fixed in newer VTE versions. I actually meant to set up lxterminal to use GTK3 in the first place, but didn't realize that wasn't the default until
now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lheckemann
Copy link
Member

@GrahamcOfBorg build lxterminal

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘lxterminal-0.3.1’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/misc/lxterminal/default.nix:38 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h5las56ja3rqfjx2h3z56as9s7cn2p0n-lxterminal-0.3.1
shrinking /nix/store/h5las56ja3rqfjx2h3z56as9s7cn2p0n-lxterminal-0.3.1/bin/lxterminal
gzipping man pages under /nix/store/h5las56ja3rqfjx2h3z56as9s7cn2p0n-lxterminal-0.3.1/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/h5las56ja3rqfjx2h3z56as9s7cn2p0n-lxterminal-0.3.1/bin 
patching script interpreter paths in /nix/store/h5las56ja3rqfjx2h3z56as9s7cn2p0n-lxterminal-0.3.1
checking for references to /tmp/nix-build-lxterminal-0.3.1.drv-0 in /nix/store/h5las56ja3rqfjx2h3z56as9s7cn2p0n-lxterminal-0.3.1...
/nix/store/h5las56ja3rqfjx2h3z56as9s7cn2p0n-lxterminal-0.3.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4xfxysinfp5ayrhxw4v5rj3zwy6s77hl-lxterminal-0.3.1
shrinking /nix/store/4xfxysinfp5ayrhxw4v5rj3zwy6s77hl-lxterminal-0.3.1/bin/lxterminal
gzipping man pages under /nix/store/4xfxysinfp5ayrhxw4v5rj3zwy6s77hl-lxterminal-0.3.1/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4xfxysinfp5ayrhxw4v5rj3zwy6s77hl-lxterminal-0.3.1/bin
patching script interpreter paths in /nix/store/4xfxysinfp5ayrhxw4v5rj3zwy6s77hl-lxterminal-0.3.1
checking for references to /build in /nix/store/4xfxysinfp5ayrhxw4v5rj3zwy6s77hl-lxterminal-0.3.1...
/nix/store/4xfxysinfp5ayrhxw4v5rj3zwy6s77hl-lxterminal-0.3.1

@lheckemann
Copy link
Member

LGTM!

@velovix @jtojnar
lxterminal: switch to using GTK3
4b9b82c 
The version of VTE that uses GTK2 is not maintained, so using lxterminal
with GTK2 means dealing with a lot of bugs that have already been fixed
in newer VTE versions. I actually meant to set up lxterminal to use GTK3
in the first place, but didn't realize that wasn't the default until
now.
@jtojnar
Copy link
Contributor

jtojnar commented Feb 25, 2018

Thanks.

@jtojnar jtojnar merged commit 4b9b82c into NixOS:master Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@velovix @lheckemann @GrahamcOfBorg @jtojnar