New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geckodriver: use devel version with slog fix #35507
Conversation
Does this build? |
@GrahamcOfBorg build geckodriver |
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
I already made a screenshot with selenium 🐍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that, seems fine.
, rustPlatform | ||
}: | ||
|
||
with rustPlatform; | ||
|
||
buildRustPackage rec { | ||
version = "0.19.1"; | ||
version = "0.19.x-devel"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From https://nixos.org/nixpkgs/manual/#sec-package-naming:
If a package is not a release but a commit from a repository, then the version part of the name must be the date of that (fetched) commit. The date must be in "YYYY-MM-DD" format. Also append "unstable" to the name - e.g., "pkgname-unstable-2014-09-23".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
force pushed 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick
, rustPlatform | ||
}: | ||
|
||
with rustPlatform; | ||
|
||
buildRustPackage rec { | ||
version = "0.19.1"; | ||
version = "0.19-unstable-2018-02-24"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version = "unstable-2018-02-24";
Resolved. force pushed again |
Motivation for this change
geckodriver does not compile. see #35301
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)