Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geckodriver: use devel version with slog fix #35507

Merged
merged 1 commit into from Mar 1, 2018

Conversation

mguentner
Copy link
Contributor

Motivation for this change

geckodriver does not compile. see #35301

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthiasbeyer
Copy link
Contributor

Does this build?

@dotlambda
Copy link
Member

@GrahamcOfBorg build geckodriver

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/native'
cp: -r not specified; omitting directory 'target/release/examples'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ibb375pk56sj5hm1n1maya8ma6w6xcws-geckodriver-0.19.x-devel
shrinking /nix/store/ibb375pk56sj5hm1n1maya8ma6w6xcws-geckodriver-0.19.x-devel/bin/geckodriver
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ibb375pk56sj5hm1n1maya8ma6w6xcws-geckodriver-0.19.x-devel/bin 
patching script interpreter paths in /nix/store/ibb375pk56sj5hm1n1maya8ma6w6xcws-geckodriver-0.19.x-devel
checking for references to /tmp/nix-build-geckodriver-0.19.x-devel.drv-0 in /nix/store/ibb375pk56sj5hm1n1maya8ma6w6xcws-geckodriver-0.19.x-devel...
/nix/store/ibb375pk56sj5hm1n1maya8ma6w6xcws-geckodriver-0.19.x-devel

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/native'
cp: -r not specified; omitting directory 'target/release/deps'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xnqk300jnvcqv7vp98f7zgv9h2jiar72-geckodriver-0.19.x-devel
shrinking /nix/store/xnqk300jnvcqv7vp98f7zgv9h2jiar72-geckodriver-0.19.x-devel/bin/geckodriver
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/xnqk300jnvcqv7vp98f7zgv9h2jiar72-geckodriver-0.19.x-devel/bin
patching script interpreter paths in /nix/store/xnqk300jnvcqv7vp98f7zgv9h2jiar72-geckodriver-0.19.x-devel
checking for references to /build in /nix/store/xnqk300jnvcqv7vp98f7zgv9h2jiar72-geckodriver-0.19.x-devel...
/nix/store/xnqk300jnvcqv7vp98f7zgv9h2jiar72-geckodriver-0.19.x-devel

@mguentner
Copy link
Contributor Author

I already made a screenshot with selenium 🐍

Copy link
Member

@jraygauthier jraygauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, seems fine.

, rustPlatform
}:

with rustPlatform;

buildRustPackage rec {
version = "0.19.1";
version = "0.19.x-devel";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://nixos.org/nixpkgs/manual/#sec-package-naming:

If a package is not a release but a commit from a repository, then the version part of the name must be the date of that (fetched) commit. The date must be in "YYYY-MM-DD" format. Also append "unstable" to the name - e.g., "pkgname-unstable-2014-09-23".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

force pushed 🔥

Copy link
Member

@jraygauthier jraygauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick

, rustPlatform
}:

with rustPlatform;

buildRustPackage rec {
version = "0.19.1";
version = "0.19-unstable-2018-02-24";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version = "unstable-2018-02-24";

@mguentner
Copy link
Contributor Author

Resolved. force pushed again

@globin globin merged commit 452f9ca into NixOS:master Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants