Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pytest-cram: 0.1.1 -> 0.2.0 #34678

Merged
merged 1 commit into from Feb 8, 2018
Merged

pythonPackages.pytest-cram: 0.1.1 -> 0.2.0 #34678

merged 1 commit into from Feb 8, 2018

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Feb 6, 2018

Motivation for this change

This fixes pytest-cram after the recent pytest upgrading broke it.

I ran nox-review but the problem is that some packages that depend on this package are still broken because of other reasons (probably pytest upgrade). I did manage to build this package with nix-shell -p pythonPackages.pytest-cram.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jluttine jluttine requested a review from FRidh as a code owner February 6, 2018 19:26
dotlambda
dotlambda reviewed Feb 6, 2018
View reviewed changes
pkgs/development/python-modules/pytest-cram/default.nix Outdated
@@ -2,15 +2,16 @@

buildPythonPackage rec {
name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get rid of the name attribute. It isn't needed anymore for buildPython*.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks. Done.

@jluttine
pythonPackages.pytest-cram: 0.1.1 -> 0.2.0
4450919 
This fixes pytest-cram after the recent pytest upgrading broke it.
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.pytest-cram python3.pkgs.pytest-cram

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

pytest_cram/tests/test_examples.py ........                              [ 53%]
pytest_cram/tests/test_options.py .......                                [100%]

========================== 15 passed in 3.02 seconds ===========================
pytest_cram/tests/test_examples.py ........                              [ 53%]
pytest_cram/tests/test_options.py .......                                [100%]

========================== 15 passed in 2.93 seconds ===========================
/nix/store/vbppxkmzwvdy69zr80wsd3r7h2dkz9v3-python2.7-pytest-cram-0.2.0
/nix/store/7wis535rgk1b4fvkxkk29k3hy32jgh01-python3.6-pytest-cram-0.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

pytest_cram/tests/test_examples.py ..                              [ 53%]
pytest_cram/tests/test_options.py .............                              [ 53%]
pytest_cram/tests/test_options.py ..                                [100%]

========================== 15 passed in 0.93 seconds ===========================
......                                [100%]

========================== 15 passed in 0.81 seconds ===========================
/nix/store/2r2kbwxmgzqdm61wlhd5zpjhaf19y927-python2.7-pytest-cram-0.2.0
/nix/store/20kg2kd1nd469sdyln7q9g98ckbay3mc-python3.6-pytest-cram-0.2.0

@FRidh FRidh merged commit 2e6032f into NixOS:master Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jluttine @dotlambda @GrahamcOfBorg @FRidh