Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8_3_16_14: fix on darwin #34685

Merged
merged 1 commit into from Feb 8, 2018
Merged

v8_3_16_14: fix on darwin #34685

merged 1 commit into from Feb 8, 2018

Conversation

cransom
Copy link
Contributor

@cransom cransom commented Feb 6, 2018 •
edited

Motivation for this change

v8_3_16_14 has been broken for quite a while under Darwin and have some development needs to have it work across Darwin and Linux hosts.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

v8_3_16_14: fix on darwin
72cd8c0 
This was switched to use gcc5 for all platforms due to a mkSnapshot
error, which fixes Linux but currently fails for Darwin. I'm unsure if
there are other runtime failures, but this hasn't been building for
quite some time.
@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Feb 8, 2018
@LnL7
Copy link
Member

LnL7 commented Feb 8, 2018

@GrahamcOfBorg build v8_3_16_14

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)


  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 1047k  100 1047k    0     0  1976k      0 --:--:-- --:--:-- --:--:-- 1976k

fetching path ‘/nix/store/z3bx8c3gyw14a1fn0f5skqdrqknclp47-v8-3.16.14.11’...

*** Downloading ‘https://cache.nixos.org/nar/00n0khgb31nzvc9a5fcb0nyxlxn4iavihxkn697winql7kkddj4l.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/z3bx8c3gyw14a1fn0f5skqdrqknclp47-v8-3.16.14.11’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 1557k  100 1557k    0     0  2528k      0 --:--:-- --:--:-- --:--:-- 2528k

/nix/store/z3bx8c3gyw14a1fn0f5skqdrqknclp47-v8-3.16.14.11

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

../src/x64/assembler-x64.h:468:40: error: 'V8_UINT64_C' was not declared in this scope
     return (supported_ & (V8_UINT64_C(1) << f)) != 0;
                                        ^
make: *** [tools/gyp/v8_base.target.mk:225: /build/v8-3.16.14.11/out/Release/obj.target/v8_base/src/hydrogen.o] Error 1
make: *** [tools/gyp/v8_base.target.mk:225: /build/v8-3.16.14.11/out/Release/obj.target/v8_base/src/codegen.o] Error 1
make: *** [tools/gyp/v8_base.target.mk:225: /build/v8-3.16.14.11/out/Release/obj.target/v8_base/src/jsregexp.o] Error 1
make: *** [tools/gyp/v8_base.target.mk:225: /build/v8-3.16.14.11/out/Release/obj.target/v8_base/src/lithium-allocator.o] Error 1
make: Leaving directory '/build/v8-3.16.14.11/out'
builder for '/nix/store/aqfpq4vrw87l23clgvwdni61p1m8l9as-v8-3.16.14.11.drv' failed with exit code 2
error: build of '/nix/store/aqfpq4vrw87l23clgvwdni61p1m8l9as-v8-3.16.14.11.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

'include/v8-testing.h' -> '/nix/store/bsibdfvx0pmhh9bi9k6fc83s3byg89hp-v8-3.16.14.11/include/v8-testing.h'
'include/v8.h' -> '/nix/store/bsibdfvx0pmhh9bi9k6fc83s3byg89hp-v8-3.16.14.11/include/v8.h'
'include/v8stdint.h' -> '/nix/store/bsibdfvx0pmhh9bi9k6fc83s3byg89hp-v8-3.16.14.11/include/v8stdint.h'
'include/v8-debug.h' -> '/nix/store/bsibdfvx0pmhh9bi9k6fc83s3byg89hp-v8-3.16.14.11/include/v8-debug.h'
'include/v8-profiler.h' -> '/nix/store/bsibdfvx0pmhh9bi9k6fc83s3byg89hp-v8-3.16.14.11/include/v8-profiler.h'
post-installation fixup
strip is /nix/store/5a88zk3jgimdmzg8rfhvm93kxib3njf9-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/bsibdfvx0pmhh9bi9k6fc83s3byg89hp-v8-3.16.14.11/lib  /nix/store/bsibdfvx0pmhh9bi9k6fc83s3byg89hp-v8-3.16.14.11/bin
patching script interpreter paths in /nix/store/bsibdfvx0pmhh9bi9k6fc83s3byg89hp-v8-3.16.14.11
/nix/store/bsibdfvx0pmhh9bi9k6fc83s3byg89hp-v8-3.16.14.11

@LnL7
Copy link
Member

LnL7 commented Feb 8, 2018

There are probably a bunch of instances like this in all-packages. I'll try to go over those as part of ZHF for 18.03 soon.

@LnL7 LnL7 merged commit 693ab60 into NixOS:master Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cransom @LnL7 @GrahamcOfBorg