Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build failures with DBD-SQLite #34688

Merged
merged 1 commit into from Feb 10, 2018
Merged

Fix build failures with DBD-SQLite #34688

merged 1 commit into from Feb 10, 2018

Conversation

andrew-d
Copy link
Contributor

@andrew-d andrew-d commented Feb 7, 2018 •
edited

Motivation for this change

This passes the correct compilation flags to the builder so we pick up the path to sqlite, and (despite the fact that it's a development version), also updates to version 1.55_07 to fix DBD-SQLite/DBD-SQLite#28.

Prior to this, we saw the following error (from the linked issue):

couldn't eval q{sub {my ($self, $i) = @_; my $row = $self->row($i); (defined($row->[1]) && defined($vals[0]) && $row->[1]  $vals[0])}} : syntax error at (eval 20) line 1, near "]  $vals"

And the error Note (probably harmless): No library found for -lsqlite3 from MakeMaker.

NOTE: I still need to try a build of this on NixOS later this evening; currently, this builds on Debian 9 + nix, but I want to confirm.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andrew-d
Fix build failures with DBD-SQLite
d3f76d7 
This passes the correct compilation flags to the builder so we pick up
the path to sqlite, and (despite the fact that it's a development
version), also updates to version 1.55_07 to fix
DBD-SQLite/DBD-SQLite#28
@Mic92
Copy link
Member

Mic92 commented Feb 10, 2018

@GrahamcOfBorg build perlPackages.DBDSQLite

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

post-installation fixup
Moving /nix/store/c2qmg7jy4y9j0i6dgjdbl6b9zbvf84c9-perl-DBD-SQLite-1.55_07/share/man/man3 to /nix/store/6qclipiidv7f1l4iajazj4dxgdq9g3gb-perl-DBD-SQLite-1.55_07-devdoc/share/man/man3
Removing empty /nix/store/c2qmg7jy4y9j0i6dgjdbl6b9zbvf84c9-perl-DBD-SQLite-1.55_07/share/man/ and (possibly) its parents
strip is /nix/store/5a88zk3jgimdmzg8rfhvm93kxib3njf9-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/c2qmg7jy4y9j0i6dgjdbl6b9zbvf84c9-perl-DBD-SQLite-1.55_07/lib
patching script interpreter paths in /nix/store/c2qmg7jy4y9j0i6dgjdbl6b9zbvf84c9-perl-DBD-SQLite-1.55_07
gzipping man pages under /nix/store/6qclipiidv7f1l4iajazj4dxgdq9g3gb-perl-DBD-SQLite-1.55_07-devdoc/share/man/
strip is /nix/store/5a88zk3jgimdmzg8rfhvm93kxib3njf9-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/6qclipiidv7f1l4iajazj4dxgdq9g3gb-perl-DBD-SQLite-1.55_07-devdoc
/nix/store/c2qmg7jy4y9j0i6dgjdbl6b9zbvf84c9-perl-DBD-SQLite-1.55_07

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/hgq89klh00gvv9hw05xv7pjscywhb7m0-perl-DBD-SQLite-1.55_07/lib 
patching script interpreter paths in /nix/store/hgq89klh00gvv9hw05xv7pjscywhb7m0-perl-DBD-SQLite-1.55_07
checking for references to /tmp/nix-build-perl-DBD-SQLite-1.55_07.drv-0 in /nix/store/hgq89klh00gvv9hw05xv7pjscywhb7m0-perl-DBD-SQLite-1.55_07...
shrinking RPATHs of ELF executables and libraries in /nix/store/7s9i6vzb4mn9iklkmdfp13yq1w83g7ij-perl-DBD-SQLite-1.55_07-devdoc
gzipping man pages under /nix/store/7s9i6vzb4mn9iklkmdfp13yq1w83g7ij-perl-DBD-SQLite-1.55_07-devdoc/share/man/
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/7s9i6vzb4mn9iklkmdfp13yq1w83g7ij-perl-DBD-SQLite-1.55_07-devdoc
checking for references to /tmp/nix-build-perl-DBD-SQLite-1.55_07.drv-0 in /nix/store/7s9i6vzb4mn9iklkmdfp13yq1w83g7ij-perl-DBD-SQLite-1.55_07-devdoc...
/nix/store/hgq89klh00gvv9hw05xv7pjscywhb7m0-perl-DBD-SQLite-1.55_07

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/v6rbwgj911n6x7wmz3x52nic3scb03jf-perl-DBD-SQLite-1.55_07/lib
patching script interpreter paths in /nix/store/v6rbwgj911n6x7wmz3x52nic3scb03jf-perl-DBD-SQLite-1.55_07
checking for references to /build in /nix/store/v6rbwgj911n6x7wmz3x52nic3scb03jf-perl-DBD-SQLite-1.55_07...
shrinking RPATHs of ELF executables and libraries in /nix/store/5k2wiqxy2z79j6givc9r7nii85dmnz0p-perl-DBD-SQLite-1.55_07-devdoc
gzipping man pages under /nix/store/5k2wiqxy2z79j6givc9r7nii85dmnz0p-perl-DBD-SQLite-1.55_07-devdoc/share/man/
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/5k2wiqxy2z79j6givc9r7nii85dmnz0p-perl-DBD-SQLite-1.55_07-devdoc
checking for references to /build in /nix/store/5k2wiqxy2z79j6givc9r7nii85dmnz0p-perl-DBD-SQLite-1.55_07-devdoc...
/nix/store/v6rbwgj911n6x7wmz3x52nic3scb03jf-perl-DBD-SQLite-1.55_07

@Mic92 Mic92 merged commit 2c5c928 into NixOS:master Feb 10, 2018
@andrew-d andrew-d deleted the adunham/dbd-sqlite branch February 10, 2018 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

t/virtual_table/rt_99748.t fails with libsqlite3 3.21.0
3 participants
@andrew-d @Mic92 @GrahamcOfBorg