Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.cil: fix build on Darwin #35282

Merged
merged 1 commit into from Feb 21, 2018
Merged

ocamlPackages.cil: fix build on Darwin #35282

merged 1 commit into from Feb 21, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Feb 21, 2018

Motivation for this change

cil does not build on Darwin: gcc cannot be found.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Feb 21, 2018
@LnL7
Copy link
Member

LnL7 commented Feb 21, 2018

@GrahamcOfBorg build ocamlPackages.cil

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

Installing /nix/store/f7ikbh6yhyi6ayz8m711g3y4zr47ms8b-ocaml-cil-1.7.3/bin/cilly
make[1]: Leaving directory '/build/cil-1.7.3/lib'
/nix/store/iifwskzsm4jdapja57w9zasmvz830wg7-coreutils-8.29/bin/install -c -m 0755 bin/cilly.* /nix/store/f7ikbh6yhyi6ayz8m711g3y4zr47ms8b-ocaml-cil-1.7.3/bin
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/f7ikbh6yhyi6ayz8m711g3y4zr47ms8b-ocaml-cil-1.7.3
shrinking /nix/store/f7ikbh6yhyi6ayz8m711g3y4zr47ms8b-ocaml-cil-1.7.3/bin/cilly.native
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/f7ikbh6yhyi6ayz8m711g3y4zr47ms8b-ocaml-cil-1.7.3/lib  /nix/store/f7ikbh6yhyi6ayz8m711g3y4zr47ms8b-ocaml-cil-1.7.3/bin
patching script interpreter paths in /nix/store/f7ikbh6yhyi6ayz8m711g3y4zr47ms8b-ocaml-cil-1.7.3
checking for references to /build in /nix/store/f7ikbh6yhyi6ayz8m711g3y4zr47ms8b-ocaml-cil-1.7.3...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

make[1]: Leaving directory '/build/cil-1.7.3/lib'
/nix/store/v9qcwraxmcv4s5v62slzkbwk9182izs9-coreutils-8.29/bin/install -c -m 0755 bin/cilly.* /nix/store/wz66awjpm842y237l71l3sdicakbzjcs-ocaml-cil-1.7.3/bin
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wz66awjpm842y237l71l3sdicakbzjcs-ocaml-cil-1.7.3
shrinking /nix/store/wz66awjpm842y237l71l3sdicakbzjcs-ocaml-cil-1.7.3/bin/cilly.native
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/wz66awjpm842y237l71l3sdicakbzjcs-ocaml-cil-1.7.3/lib  /nix/store/wz66awjpm842y237l71l3sdicakbzjcs-ocaml-cil-1.7.3/bin
patching script interpreter paths in /nix/store/wz66awjpm842y237l71l3sdicakbzjcs-ocaml-cil-1.7.3
checking for references to /build in /nix/store/wz66awjpm842y237l71l3sdicakbzjcs-ocaml-cil-1.7.3...
/nix/store/wz66awjpm842y237l71l3sdicakbzjcs-ocaml-cil-1.7.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

Installing /nix/store/c0w3wb27hl01k3l94zydwl3xga7pj9c3-ocaml-cil-1.7.3/lib/perl5/App/Cilly/KeptFile.pm
Installing /nix/store/c0w3wb27hl01k3l94zydwl3xga7pj9c3-ocaml-cil-1.7.3/lib/perl5/App/Cilly/OutputFile.pm
Installing /nix/store/c0w3wb27hl01k3l94zydwl3xga7pj9c3-ocaml-cil-1.7.3/lib/perl5/App/Cilly/TempFile.pm
Installing /nix/store/c0w3wb27hl01k3l94zydwl3xga7pj9c3-ocaml-cil-1.7.3/bin/cilly
make[1]: Leaving directory '/private/tmp/nix-build-ocaml-cil-1.7.3.drv-0/cil-1.7.3/lib'
/nix/store/5wxjmr5ahlnk2ljkhv5fia1w46qv8ajp-coreutils-8.29/bin/install -c -m 0755 bin/cilly.* /nix/store/c0w3wb27hl01k3l94zydwl3xga7pj9c3-ocaml-cil-1.7.3/bin
post-installation fixup
strip is /nix/store/v8ifq0hapblpr2z0hx4wvwg02w4aczqy-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/c0w3wb27hl01k3l94zydwl3xga7pj9c3-ocaml-cil-1.7.3/lib  /nix/store/c0w3wb27hl01k3l94zydwl3xga7pj9c3-ocaml-cil-1.7.3/bin
patching script interpreter paths in /nix/store/c0w3wb27hl01k3l94zydwl3xga7pj9c3-ocaml-cil-1.7.3

@LnL7 LnL7 merged commit 7418eb6 into NixOS:master Feb 21, 2018
@vbgl vbgl deleted the ocaml-cil-darwin branch February 21, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
0.kind: bug 6.topic: darwin Running or building packages on Darwin 6.topic: ocaml 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @LnL7 @GrahamcOfBorg