Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keepass-keepassrpc: init at 1.7.3.1 #35291

Merged
merged 1 commit into from Feb 23, 2018
Merged

keepass-keepassrpc: init at 1.7.3.1 #35291

merged 1 commit into from Feb 23, 2018

Conversation

svsdep
Copy link
Contributor

@svsdep svsdep commented Feb 21, 2018

Motivation for this change

Repackaged as the name was confusing and there is a dedicated repository
for this plugin, ready to use and with the fresh plugin version.
Left an alias to an old package name.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@svsdep svsdep changed the title keepass-keepassrpc: 1.6.4 -> 1.7.3.1 keepass-keepassrpc: init at 1.7.3.1 Feb 21, 2018
@grahamc
Copy link
Member

grahamc commented Feb 22, 2018

@GrahamcOfBorg build keepass-keepassrpc

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘mono-4.0.4.1’ in /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/pkgs/development/compilers/mono/generic.nix:90 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

fetching path ‘/nix/store/r0b963r1hkgzkwza13zdpd6mq8q80b5f-mono-4.0.4.1’...

*** Downloading ‘https://cache.nixos.org/nar/0493h2wkj6imrkykcslkksrmdlgwxidg3n9yr21pfq7ypv4cn6pk.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/r0b963r1hkgzkwza13zdpd6mq8q80b5f-mono-4.0.4.1’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  3 83.0M    3 2921k    0     0  3927k      0  0:00:21 --:--:--  0:00:21 3921k
 18 83.0M   18 15.4M    0     0  9049k      0  0:00:09  0:00:01  0:00:08 9044k
 33 83.0M   33 27.6M    0     0  10.0M      0  0:00:08  0:00:02  0:00:06 10.0M
 47 83.0M   47 39.5M    0     0  10.5M      0  0:00:07  0:00:03  0:00:04 10.5M
 62 83.0M   62 51.5M    0     0  10.7M      0  0:00:07  0:00:04  0:00:03 10.7M
 76 83.0M   76 63.4M    0     0  10.9M      0  0:00:07  0:00:05  0:00:02 11.9M
 94 83.0M   94 78.4M    0     0  11.5M      0  0:00:07  0:00:06  0:00:01 12.5M
100 83.0M  100 83.0M    0     0  11.7M      0  0:00:07  0:00:07 --:--:-- 12.8M

building path(s) ‘/nix/store/pbs43gw4fkn4mz8ip1a97kdr7w526ysi-keepassrpc-1.7.3.1’
created 53 symlinks in user environment
/nix/store/pbs43gw4fkn4mz8ip1a97kdr7w526ysi-keepassrpc-1.7.3.1

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘keepassrpc-1.7.3.1’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/misc/keepass-plugins/keepassrpc/default.nix:13 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@svsdep
Copy link
Contributor Author

svsdep commented Feb 22, 2018

Locked to x86_64-linux platform as it is linux-only and mono doesn't support aarch64-linux platform.

@svsdep
keepass-keepassrpc: init at 1.7.3.1
fc42c85 
Repackaged as the name was confusing and there is a dedicated repository
for this plugin, ready to use and with the fresh plugin version.
Left an alias to an old package name.
@svsdep
Copy link
Contributor Author

svsdep commented Feb 22, 2018

Should I also add assert stdenv.system == "x86_64-linux"; for build bots not to try to build it on unsupported platforms, or specifying correct platforms is enough?

@fpletz
Copy link
Member

fpletz commented Feb 23, 2018

That's fine. Hydra won't try to build but @GrahamcOfBorg is not there yet. :)

@fpletz fpletz merged commit 89aab86 into NixOS:master Feb 23, 2018
@svsdep svsdep deleted the keepassrpc branch February 25, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@svsdep @grahamc @GrahamcOfBorg @fpletz