racket-minimal: build on darwin #35285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically, racket compiles and packages too, but it doesn't pass all tests yet, so the build fails. gcc7Stdenv is GCC 7 with the MacOS-specific adaptations retained. Building on MacOS with that works, but we should be using clang. I'm hoping that the next person wanting to override the compiler version in some other derivation sees that attribute and doesn't inadvertently break a MacOS build again.
LnL7
approved these changes
Feb 21, 2018
| @@ -47,9 +48,13 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| FONTCONFIG_FILE = fontsConf; | |||
| LD_LIBRARY_PATH = libPath; | |||
| NIX_LDFLAGS = stdenv.lib.optionalString stdenv.cc.isGNU "-lgcc_s"; | |||
| NIX_LDFLAGS = stdenv.lib.concatStringsSep " " [ | |||
| (stdenv.lib.optionalString (stdenv.cc.isGNU && ! stdenv.isDarwin) "-lgcc_s") | |||
There was a problem hiding this comment.
It is possible, if you want to for whatever reason, to build this package with gcc7Stdenv, just pass that as the stdenv, and in case you do, you need to not use -lgcc_s.
There was a problem hiding this comment.
That's not something we usually worry about, but I guess it doesn't hurt.
|
@GrahamcOfBorg build racket-minimal |
|
Success on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
LnL7
approved these changes
Feb 21, 2018
| @@ -47,9 +48,13 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| FONTCONFIG_FILE = fontsConf; | |||
| LD_LIBRARY_PATH = libPath; | |||
| NIX_LDFLAGS = stdenv.lib.optionalString stdenv.cc.isGNU "-lgcc_s"; | |||
| NIX_LDFLAGS = stdenv.lib.concatStringsSep " " [ | |||
| (stdenv.lib.optionalString (stdenv.cc.isGNU && ! stdenv.isDarwin) "-lgcc_s") | |||
There was a problem hiding this comment.
That's not something we usually worry about, but I guess it doesn't hurt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically, racket compiles and packages too, but it doesn't pass all
tests yet, so the build fails.
gcc7Stdenv is GCC 7 with the MacOS-specific adaptations retained.
Building on MacOS with that works, but we should be using clang.
I'm hoping that the next person wanting to override the compiler
version in some other derivation sees that attribute and doesn't
inadvertently break a MacOS build again.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)