Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exim: 4.90 -> 4.90.1 #34816

Merged
merged 1 commit into from Feb 10, 2018
Merged

exim: 4.90 -> 4.90.1 #34816

merged 1 commit into from Feb 10, 2018

Conversation

4z3
Copy link
Contributor

@4z3 4z3 commented Feb 10, 2018 •
edited

Motivation for this change

Fixes CVE-2018-6789.

Refs https://lists.exim.org/lurker/message/20180210.180351.bc65dc61.en.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fpletz
Copy link
Member

fpletz commented Feb 10, 2018

@GrahamcOfBorg build exim

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘exim-4.90.1’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/servers/mail/exim/default.nix:59 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

gzipping man pages under /nix/store/0dwjbbc1gj2l7mfkqh32wigrbsfqzc4d-exim-4.90.1/share/man/
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/0dwjbbc1gj2l7mfkqh32wigrbsfqzc4d-exim-4.90.1/bin 
patching script interpreter paths in /nix/store/0dwjbbc1gj2l7mfkqh32wigrbsfqzc4d-exim-4.90.1
/nix/store/0dwjbbc1gj2l7mfkqh32wigrbsfqzc4d-exim-4.90.1/bin/exicyclog: interpreter directive changed from " /bin/sh" to "/nix/store/yq03c2ny43mc24j7dq5riznzb09ddhpq-bash-4.4-p12/bin/sh"
/nix/store/0dwjbbc1gj2l7mfkqh32wigrbsfqzc4d-exim-4.90.1/bin/exinext: interpreter directive changed from " /bin/sh" to "/nix/store/yq03c2ny43mc24j7dq5riznzb09ddhpq-bash-4.4-p12/bin/sh"
/nix/store/0dwjbbc1gj2l7mfkqh32wigrbsfqzc4d-exim-4.90.1/bin/exim_checkaccess: interpreter directive changed from " /bin/sh" to "/nix/store/yq03c2ny43mc24j7dq5riznzb09ddhpq-bash-4.4-p12/bin/sh"
/nix/store/0dwjbbc1gj2l7mfkqh32wigrbsfqzc4d-exim-4.90.1/bin/exiwhat: interpreter directive changed from " /bin/sh" to "/nix/store/yq03c2ny43mc24j7dq5riznzb09ddhpq-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-exim-4.90.1.drv-0 in /nix/store/0dwjbbc1gj2l7mfkqh32wigrbsfqzc4d-exim-4.90.1...
/nix/store/0dwjbbc1gj2l7mfkqh32wigrbsfqzc4d-exim-4.90.1

@fpletz fpletz merged commit 274de25 into NixOS:master Feb 10, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

gzipping man pages under /nix/store/0bzls42hkzb9g8yf7c6jsyhj632b3rxc-exim-4.90.1/share/man/
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/0bzls42hkzb9g8yf7c6jsyhj632b3rxc-exim-4.90.1/bin
patching script interpreter paths in /nix/store/0bzls42hkzb9g8yf7c6jsyhj632b3rxc-exim-4.90.1
/nix/store/0bzls42hkzb9g8yf7c6jsyhj632b3rxc-exim-4.90.1/bin/exiwhat: interpreter directive changed from " /bin/sh" to "/nix/store/7fxbh1yhagvwbdrmdyyy5ghcjhwjndhs-bash-4.4-p12/bin/sh"
/nix/store/0bzls42hkzb9g8yf7c6jsyhj632b3rxc-exim-4.90.1/bin/exinext: interpreter directive changed from " /bin/sh" to "/nix/store/7fxbh1yhagvwbdrmdyyy5ghcjhwjndhs-bash-4.4-p12/bin/sh"
/nix/store/0bzls42hkzb9g8yf7c6jsyhj632b3rxc-exim-4.90.1/bin/exim_checkaccess: interpreter directive changed from " /bin/sh" to "/nix/store/7fxbh1yhagvwbdrmdyyy5ghcjhwjndhs-bash-4.4-p12/bin/sh"
/nix/store/0bzls42hkzb9g8yf7c6jsyhj632b3rxc-exim-4.90.1/bin/exicyclog: interpreter directive changed from " /bin/sh" to "/nix/store/7fxbh1yhagvwbdrmdyyy5ghcjhwjndhs-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/0bzls42hkzb9g8yf7c6jsyhj632b3rxc-exim-4.90.1...
/nix/store/0bzls42hkzb9g8yf7c6jsyhj632b3rxc-exim-4.90.1

@4z3 4z3 deleted the exim-4.90.1 branch February 10, 2018 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@4z3 @fpletz @GrahamcOfBorg