libfabric parcelport w/o HPX_PARCELPORT_LIBFABRIC_ENDPOINT_RDM #3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ct-clmsn
changed the title
|
just found a method that converts endpoints to active endpoints. will fix circleci/appveyor issues and swap out the logic to use the existing method. |
…X_PARCELPORT_LIBFABRIC_ENDPOINT_RDM
|
@ct-clmsn could you please give me access to your clone, so that I can rebase this PR and add a commit to it |
|
It seems you can make individual PR's editable too |
biddisco
force-pushed
the
libfabric_passive_to_active_non_endpoint_rdm
branch
from
7fd7222
to
0af29b9
Compare
|
Apologies. I already had permission. I didn't try it right. I've rebased this branch onto current master and force pushed. I hope this does not cause trouble at your end |
|
@biddisco no problem! thank you for the help (picking up my slack and for the review)! |
|
Merging this after testing locally. Need it to be ready if GSoC project goes ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HPX_PARCELPORT_LIBFABRIC_ENDPOINT_RDM fixes.
Fixes #2650
Any background context you want to provide?
platforms without LIBFABRIC_ENDPOINT_RDM turned on have compile time errors. this patch resolves compile issues. this patch also fixes an issue where the passive endpoint is not turned into an active endpoint for IPC. without this fix active endpoints are never created; active endpoints are created only in blocks of code with the HPX_PARCELPORT_LIBFABRIC_ENDPOINT_RDM #define guard. active endpoints are necessary for IPC.