Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oxipng: init at 1.0.0 #34829

Merged
merged 2 commits into from Feb 12, 2018
Merged

oxipng: init at 1.0.0 #34829

merged 2 commits into from Feb 12, 2018

Conversation

ghost
Copy link

@ghost ghost commented Feb 11, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fpletz
Copy link
Member

fpletz commented Feb 12, 2018

@GrahamcOfBorg build oxipng

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/native'
cp: -r not specified; omitting directory 'target/release/examples'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wgpkhz6g5hxv6nna7bsfifq33m5hnbyb-oxipng-1.0.0
shrinking /nix/store/wgpkhz6g5hxv6nna7bsfifq33m5hnbyb-oxipng-1.0.0/bin/oxipng
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/wgpkhz6g5hxv6nna7bsfifq33m5hnbyb-oxipng-1.0.0/bin 
patching script interpreter paths in /nix/store/wgpkhz6g5hxv6nna7bsfifq33m5hnbyb-oxipng-1.0.0
checking for references to /tmp/nix-build-oxipng-1.0.0.drv-0 in /nix/store/wgpkhz6g5hxv6nna7bsfifq33m5hnbyb-oxipng-1.0.0...
/nix/store/wgpkhz6g5hxv6nna7bsfifq33m5hnbyb-oxipng-1.0.0

fpletz
fpletz reviewed Feb 12, 2018
View reviewed changes
pkgs/tools/graphics/oxipng/default.nix Outdated
{ stdenv, fetchFromGitHub, rustPlatform }:

rustPlatform.buildRustPackage rec {
version = "1.0.0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick: Please indent with 2 spaces. 😉

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/build'
cp: -r not specified; omitting directory 'target/release/deps'
cp: -r not specified; omitting directory 'target/release/examples'
cp: -r not specified; omitting directory 'target/release/incremental'
cp: -r not specified; omitting directory 'target/release/native'
post-installation fixup
strip is /nix/store/5a88zk3jgimdmzg8rfhvm93kxib3njf9-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/7j0wv3a7ipn9iq20ykmcb33k82d21s0f-oxipng-1.0.0/bin
patching script interpreter paths in /nix/store/7j0wv3a7ipn9iq20ykmcb33k82d21s0f-oxipng-1.0.0
/nix/store/7j0wv3a7ipn9iq20ykmcb33k82d21s0f-oxipng-1.0.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

cannot build derivation '/nix/store/0jribyf3qxfdl60lgpqgnfali7ai95ib-rust_serde_derive-1.0.18.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/kyglwvsprq1in2xnjg6mx9rnccidmy6f-rust_crates-io-0.11.0.drv': 30 dependencies couldn't be built
cannot build derivation '/nix/store/49yfi2522frhdq6i8hms6hjndqhv6sik-rust_docopt-0.8.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/x3nxrrggzq7znif7b32kb3a7f1rz4a49-rust_git2-curl-0.7.0.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/nzrc7j57fzrya5qyl7vqnr1rqhjg40g4-rust_ignore-0.2.2.drv': 18 dependencies couldn't be built
cannot build derivation '/nix/store/m9aq2m4jb4whd51c8jcrhvgp6igwdjqz-rust_cargo-0.22.0.drv': 78 dependencies couldn't be built
cannot build derivation '/nix/store/ir9aw7rf74r0qyxj79wbn3609prgr23c-rust_cargo-vendor-0.1.13.drv': 79 dependencies couldn't be built
cannot build derivation '/nix/store/cgda3y846835dwral0vg11qa38wdh26w-oxipng-1.0.0-vendor.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/6bqirdsd3l6ii9jhbk3s9mgp99bi86zx-oxipng-1.0.0.drv': 3 dependencies couldn't be built
error: build of '/nix/store/6bqirdsd3l6ii9jhbk3s9mgp99bi86zx-oxipng-1.0.0.drv' failed

@fpletz fpletz merged commit b22883c into NixOS:master Feb 12, 2018
@ghost ghost deleted the oxipng branch February 12, 2018 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fpletz @GrahamcOfBorg