Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nix stats: flatten statistics #1859

Merged
merged 1 commit into from Feb 13, 2018
Merged

Nix stats: flatten statistics #1859

merged 1 commit into from Feb 13, 2018

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Feb 11, 2018

Flattens the list of statistics as suggested in
NixOS/ofborg#67. This makes it easier to work
with.

@FRidh
Nix stats: flatten statistics
60eca58 
Flattens the list of statistics as suggested in
NixOS/ofborg#67. This makes it easier to work
with.
@grahamc
Copy link
Member

grahamc commented Feb 11, 2018

1/2 of #1858

vcunat
vcunat approved these changes Feb 11, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@grahamc
Copy link
Member

grahamc commented Feb 11, 2018

We'll need to fix https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/metrics.nix#L26

@edolstra
Copy link
Member

For machine processing, it's probably better to change the stats output to JSON format.

@edolstra edolstra merged commit c5cc57e into NixOS:master Feb 13, 2018
@FRidh FRidh deleted the flatten branch February 13, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlevy shlevy shlevy approved these changes

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@FRidh @grahamc @edolstra @shlevy @vcunat