Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bfs: init at 1.2.1 #34845

Merged
merged 3 commits into from Feb 11, 2018
Merged

bfs: init at 1.2.1 #34845

merged 3 commits into from Feb 11, 2018

Conversation

yesbox
Copy link
Contributor

@yesbox yesbox commented Feb 11, 2018

Adds the bfs package; a breadth-first version of the UNIX find command.
https://github.com/tavianator/bfs

This patch also introduces the "BSD Zero Clause License".

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

homepage = https://github.com/tavianator/bfs;
license = licenses.bsd0;
platforms = platforms.linux;
maintainers = [stdenv.lib.maintainers.yesbox];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "stdenv.lib" part can be removed here, as you have "with stdenv.lib" above.

Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nitpic: please split into three commits: add license, add maintainer, add package.

@yesbox
Copy link
Contributor Author

yesbox commented Feb 11, 2018

Thanks for reviewing. I've pushed again.

@Mic92 Mic92 merged commit 78ab1b0 into NixOS:master Feb 11, 2018
@yesbox yesbox deleted the bfs_init branch September 22, 2018 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants