Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/postfix: document that *Alias options support comma separated values #34843

Closed
wants to merge 1 commit into from
Closed

nixos/postfix: document that *Alias options support comma separated values #34843

wants to merge 1 commit into from

Conversation

bjornfor
Copy link
Contributor

Motivation for this change

For the longest time I thought there could be only one rootAlias.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bjornfor
nixos/postfix: document that *Alias options support comma separated v…
dfc3b6b 
…alues

For the longest time I thought there could be only one rootAlias.
fpletz
fpletz approved these changes Feb 13, 2018
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now but we should eventually convert these options to lists of strings which iirc the module system would merge nicely.

@bjornfor
Copy link
Contributor Author

Good point. (I think that'd require a custom merge function, due to the commas, but definitely possible.)

I'm always unsure of how much abstraction to put into NixOS modules :-/ I have no strong opinion whether to continue with str type (maps directly to postfix documentation) or to make it a listOf str, with custom merge function.

@bjornfor
Copy link
Contributor Author

Applied to master (d84f18e).

@bjornfor bjornfor closed this Feb 18, 2018
@bjornfor bjornfor deleted the nixos-postfix-alias-doc branch February 18, 2018 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
0.kind: enhancement 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bjornfor @fpletz @GrahamcOfBorg