lego: init at unstable-2018-02-02 #34830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlewo
requested changes
Feb 11, 2018
pkgs/tools/admin/lego/default.nix
Outdated
|
|
||
| buildGoPackage rec { | ||
| name = "lego-${version}"; | ||
| version = "0.4.2-pre-${lib.strings.substring 0 7 rev}"; |
There was a problem hiding this comment.
Since this revision is not released, can you please use for the version, the format unstable-YYYY-MM-DD as specified in https://nixos.org/nixpkgs/manual/#sec-package-naming
pkgs/tools/admin/lego/default.nix
Outdated
| version = "0.4.2-pre-${lib.strings.substring 0 7 rev}"; | ||
| rev = "06a8e7c475c03ef8d4773284ac63357d2810601b"; | ||
|
|
||
| src = fetchgit { |
There was a problem hiding this comment.
Can you please use fetchFromGitHub
pkgs/tools/admin/lego/default.nix
Outdated
|
|
||
| goPackagePath = "github.com/xenolf/lego"; | ||
| goDeps = ./deps.nix; | ||
| subPackages = [ "." ]; |
|
@nlewo - Thanks for the prompt feedback! Just pushed another commit with my updates; do you want me to squash it into the original commit? |
nlewo
approved these changes
Feb 11, 2018
andrew-d
force-pushed
the
adunham/lego
branch
from
b564794
to
ac5e4d4
Compare
|
@nlewo - Done! |
|
@GrahamcOfBorg build lego |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Partial log (click to expand)
|
|
@adisbladis - Thank you very much! 😀 |
|
@andrew-d Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adding lego, a Let's Encrypt client that supports DNS-based challenges with a variety of providers.
Dependencies were generated with go2nix today (2018-02-10).
Things done
build-use-sandboxinnix.confon non-NixOS)Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)Tested compilation of all pkgs that depend on this change usingnix-shell -p nox --run "nox-review wip"./result/bin/)