Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghostwriter: init at 1.5.0 #34815

Merged
merged 1 commit into from Feb 13, 2018
Merged

ghostwriter: init at 1.5.0 #34815

merged 1 commit into from Feb 13, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member Author

@GrahamcOfBorg build ghostwriter

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

                                                                    ^~~~~
src/sundown/html.c:524:108: warning: unused parameter 'opaque' [-Wunused-parameter]
 toc_link(struct buf *ob, const struct buf *link, const struct buf *title, const struct buf *content, void *opaque)
                                                                                                            ^~~~~~
src/sundown/markdown.c: In function 'htmlblock_end_tag':
src/sundown/markdown.c:1829:22: warning: unused parameter 'rndr' [-Wunused-parameter]
  struct sd_markdown *rndr,
                      ^~~~
builder for '/nix/store/iy2pr2g8bi36lyxpr28nbxripnbvsxd4-ghostwriter-1.5.0.drv' failed with exit code 2
error: build of '/nix/store/iy2pr2g8bi36lyxpr28nbxripnbvsxd4-ghostwriter-1.5.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/3ajc7zzdk0k42zrbniszxw2xwdsqcvx0-ghostwriter-1.5.0
shrinking /nix/store/3ajc7zzdk0k42zrbniszxw2xwdsqcvx0-ghostwriter-1.5.0/bin/ghostwriter
gzipping man pages under /nix/store/3ajc7zzdk0k42zrbniszxw2xwdsqcvx0-ghostwriter-1.5.0/share/man/
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/3ajc7zzdk0k42zrbniszxw2xwdsqcvx0-ghostwriter-1.5.0/bin 
patching script interpreter paths in /nix/store/3ajc7zzdk0k42zrbniszxw2xwdsqcvx0-ghostwriter-1.5.0
checking for references to /tmp/nix-build-ghostwriter-1.5.0.drv-0 in /nix/store/3ajc7zzdk0k42zrbniszxw2xwdsqcvx0-ghostwriter-1.5.0...
postPatchMkspecs
postPatchMkspecs
/nix/store/3ajc7zzdk0k42zrbniszxw2xwdsqcvx0-ghostwriter-1.5.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/3ajc7zzdk0k42zrbniszxw2xwdsqcvx0-ghostwriter-1.5.0
shrinking /nix/store/3ajc7zzdk0k42zrbniszxw2xwdsqcvx0-ghostwriter-1.5.0/bin/ghostwriter
gzipping man pages under /nix/store/3ajc7zzdk0k42zrbniszxw2xwdsqcvx0-ghostwriter-1.5.0/share/man/
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/3ajc7zzdk0k42zrbniszxw2xwdsqcvx0-ghostwriter-1.5.0/bin
patching script interpreter paths in /nix/store/3ajc7zzdk0k42zrbniszxw2xwdsqcvx0-ghostwriter-1.5.0
checking for references to /build in /nix/store/3ajc7zzdk0k42zrbniszxw2xwdsqcvx0-ghostwriter-1.5.0...
postPatchMkspecs
postPatchMkspecs
/nix/store/3ajc7zzdk0k42zrbniszxw2xwdsqcvx0-ghostwriter-1.5.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/5jyirjq1ql6cmwpi8cglwkfp9w6zmh30-ghostwriter-1.5.0
shrinking /nix/store/5jyirjq1ql6cmwpi8cglwkfp9w6zmh30-ghostwriter-1.5.0/bin/ghostwriter
gzipping man pages under /nix/store/5jyirjq1ql6cmwpi8cglwkfp9w6zmh30-ghostwriter-1.5.0/share/man/
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5jyirjq1ql6cmwpi8cglwkfp9w6zmh30-ghostwriter-1.5.0/bin
patching script interpreter paths in /nix/store/5jyirjq1ql6cmwpi8cglwkfp9w6zmh30-ghostwriter-1.5.0
checking for references to /build in /nix/store/5jyirjq1ql6cmwpi8cglwkfp9w6zmh30-ghostwriter-1.5.0...
postPatchMkspecs
postPatchMkspecs
/nix/store/5jyirjq1ql6cmwpi8cglwkfp9w6zmh30-ghostwriter-1.5.0

@dotlambda
Copy link
Member Author

Why did it work now when it didn't work before? I only changed meta.

@grahamc
Copy link
Member

grahamc commented Feb 10, 2018

The aarch64 builder was updated between those to builds to fix a problem with /bin/sh, which was fixed in #34628.

@dotlambda
Copy link
Member Author

Okay, thanks! Then I'll have to revisit an older PR to enable aarch64.

@joachifm joachifm merged commit 6e40e3b into NixOS:master Feb 13, 2018
@dotlambda dotlambda deleted the ghostwriter branch March 21, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @GrahamcOfBorg @grahamc @joachifm