notmuch-addrlookup: 7 -> 9 #34833

flokli · 2018-02-11T09:19:26Z

Motivation for this change

This version bump contains the following fixes:

v8:

Avoid a segmentation fault when notmuch_message_get_header() returns NULL. (Patch by Víctor M. Jáquez vjaquez@igalia.com).

v9:

Do not use the deprecated notmuch_query_count_messages_st function when using Notmuch 0.25. (Patch by Adam Ruzicka a.ruzicka@outlook.com.)
We already had this patch in our tree.
Fix crash in when running queries and the program is build with Notmuch 0.25. (Patch by Joshua Krusell joshua.krusell@v-dem.net).
Fix conditional compilation when using Notmuch 0.25. (Patch by David Bremner bremner@debian.org).

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

andir · 2018-02-11T12:50:09Z

@GrahamcOfBorg build notmuch-addrlookup

GrahamcOfBorg · 2018-02-11T12:50:49Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘notmuch-addrlookup-9’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/networking/mailreaders/notmuch-addrlookup/default.nix:22 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-11T12:51:35Z

Success on x86_64-linux (full log)

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4fm5bay4jzlng4d2lwj8b7mcbbrf7ll0-notmuch-addrlookup-9
shrinking /nix/store/4fm5bay4jzlng4d2lwj8b7mcbbrf7ll0-notmuch-addrlookup-9/bin/notmuch-addrlookup
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4fm5bay4jzlng4d2lwj8b7mcbbrf7ll0-notmuch-addrlookup-9/bin
patching script interpreter paths in /nix/store/4fm5bay4jzlng4d2lwj8b7mcbbrf7ll0-notmuch-addrlookup-9
checking for references to /build in /nix/store/4fm5bay4jzlng4d2lwj8b7mcbbrf7ll0-notmuch-addrlookup-9...
/nix/store/4fm5bay4jzlng4d2lwj8b7mcbbrf7ll0-notmuch-addrlookup-9

andir · 2018-02-11T12:54:42Z

pkgs/applications/version-management/git-and-tools/svn-all-fast-export/default.nix

@@ -10,7 +10,7 @@ stdenv.mkDerivation {
    owner = "svn-all-fast-export";
    repo = "svn2git";
    rev = version;
-    sha256 = "0lhnw8f15j4wkpswhrjd7bp9xkhbk32zmszaxayzfhbdl0g7pzwj";


Why is this in here?

Whoops, that was a mistake. fixed!

GrahamcOfBorg · 2018-02-11T13:52:07Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

   Compiling compiler_builtins v0.0.0 (file:///build/rustc-1.22.1-src/src/rustc/compiler_builtins_shim)
   Compiling std v0.0.0 (file:///build/rustc-1.22.1-src/src/libstd)
building of '/nix/store/1q00yw9nphvwvxyk6imxny1rk76rwqy1-rustc-1.22.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/i63b6jfgcjz1qkbwsljw4y9vrdsq0qr3-cargo-0.23.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/54gwpxhrss33zvavc8qpv9kvca66ja7j-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/4sgr9nibc20a50wqj0m0slhxnb5wsy2d-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/y8q9bimsr1wd2g5xf5wgbjvmww16xz3x-emacs-25.3.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/cy4rqk7y27ryya7yrhaynyis6i6bqv6l-notmuch-0.26.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/2mfyfkz94zrajxh55jyafr0pvkv0ff5c-notmuch-addrlookup-9.drv': 1 dependencies couldn't be built
error: build of '/nix/store/2mfyfkz94zrajxh55jyafr0pvkv0ff5c-notmuch-addrlookup-9.drv' failed

andir · 2018-02-11T14:04:32Z

@GrahamcOfBorg build notmuch-addrlookup

GrahamcOfBorg · 2018-02-11T14:04:52Z

Success on x86_64-linux (full log)

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4fm5bay4jzlng4d2lwj8b7mcbbrf7ll0-notmuch-addrlookup-9
shrinking /nix/store/4fm5bay4jzlng4d2lwj8b7mcbbrf7ll0-notmuch-addrlookup-9/bin/notmuch-addrlookup
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4fm5bay4jzlng4d2lwj8b7mcbbrf7ll0-notmuch-addrlookup-9/bin 
patching script interpreter paths in /nix/store/4fm5bay4jzlng4d2lwj8b7mcbbrf7ll0-notmuch-addrlookup-9
checking for references to /tmp/nix-build-notmuch-addrlookup-9.drv-0 in /nix/store/4fm5bay4jzlng4d2lwj8b7mcbbrf7ll0-notmuch-addrlookup-9...
/nix/store/4fm5bay4jzlng4d2lwj8b7mcbbrf7ll0-notmuch-addrlookup-9

GrahamcOfBorg · 2018-02-11T14:05:01Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘notmuch-addrlookup-9’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/networking/mailreaders/notmuch-addrlookup/default.nix:22 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-11T15:04:52Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

   Compiling std v0.0.0 (file:///build/rustc-1.22.1-src/src/libstd)
   Compiling alloc_jemalloc v0.0.0 (file:///build/rustc-1.22.1-src/src/liballoc_jemalloc)
building of '/nix/store/1q00yw9nphvwvxyk6imxny1rk76rwqy1-rustc-1.22.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/i63b6jfgcjz1qkbwsljw4y9vrdsq0qr3-cargo-0.23.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/54gwpxhrss33zvavc8qpv9kvca66ja7j-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/4sgr9nibc20a50wqj0m0slhxnb5wsy2d-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/y8q9bimsr1wd2g5xf5wgbjvmww16xz3x-emacs-25.3.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/cy4rqk7y27ryya7yrhaynyis6i6bqv6l-notmuch-0.26.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/2mfyfkz94zrajxh55jyafr0pvkv0ff5c-notmuch-addrlookup-9.drv': 1 dependencies couldn't be built
error: build of '/nix/store/2mfyfkz94zrajxh55jyafr0pvkv0ff5c-notmuch-addrlookup-9.drv' failed

This version bump contains the following fixes: v8: - Avoid a segmentation fault when notmuch_message_get_header() returns NULL. (Patch by Víctor M. Jáquez <vjaquez@igalia.com>). v9: - Do not use the deprecated notmuch_query_count_messages_st function when using Notmuch 0.25. (Patch by Adam Ruzicka <a.ruzicka@outlook.com>.) We already had this patch in our tree. - Fix crash in when running queries and the program is build with Notmuch 0.25. (Patch by Joshua Krusell <joshua.krusell@v-dem.net>). - Fix conditional compilation when using Notmuch 0.25. (Patch by David Bremner <bremner@debian.org>).

flokli · 2018-02-11T20:01:08Z

@andir The jemalloc issue on aarch64 looks pretty unrelated.

I don't see a reason why it shouldn't work on darwin. Could you give @GrahamcOfBorg another shot?

andir · 2018-02-11T20:04:06Z

@GrahamcOfBorg build notmuch-addrlookup

GrahamcOfBorg · 2018-02-11T20:04:29Z

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/4fm5bay4jzlng4d2lwj8b7mcbbrf7ll0-notmuch-addrlookup-9

GrahamcOfBorg · 2018-02-11T20:04:52Z

Success on x86_64-darwin (full log)

Partial log (click to expand)

clang -Wall -O2 -I/nix/store/bx10ijr9nz94vrxdkavkicqmrgf9h59n-glib-2.54.3-dev/include/glib-2.0 -I/nix/store/lxyhv5v0rgfpnn6a9jc54m7pp9mfyqns-glib-2.54.3/lib/glib-2.0/include -std=c99   -c -o notmuch-addrlookup.o notmuch-addrlookup.c
clang   notmuch-addrlookup.o  -lnotmuch -L/nix/store/lxyhv5v0rgfpnn6a9jc54m7pp9mfyqns-glib-2.54.3/lib -lglib-2.0 -o notmuch-addrlookup
glibPreInstallPhase
installing
glibPreFixupPhase
post-installation fixup
strip is /nix/store/5a88zk3jgimdmzg8rfhvm93kxib3njf9-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/s90dkxgac64mjrdysr6ja7374f5yjhs7-notmuch-addrlookup-9/bin
patching script interpreter paths in /nix/store/s90dkxgac64mjrdysr6ja7374f5yjhs7-notmuch-addrlookup-9
/nix/store/s90dkxgac64mjrdysr6ja7374f5yjhs7-notmuch-addrlookup-9

GrahamcOfBorg · 2018-02-11T21:04:27Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

   Compiling alloc_jemalloc v0.0.0 (file:///build/rustc-1.22.1-src/src/liballoc_jemalloc)
   Compiling std v0.0.0 (file:///build/rustc-1.22.1-src/src/libstd)
building of '/nix/store/1q00yw9nphvwvxyk6imxny1rk76rwqy1-rustc-1.22.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/i63b6jfgcjz1qkbwsljw4y9vrdsq0qr3-cargo-0.23.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/54gwpxhrss33zvavc8qpv9kvca66ja7j-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/4sgr9nibc20a50wqj0m0slhxnb5wsy2d-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/y8q9bimsr1wd2g5xf5wgbjvmww16xz3x-emacs-25.3.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/cy4rqk7y27ryya7yrhaynyis6i6bqv6l-notmuch-0.26.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/2mfyfkz94zrajxh55jyafr0pvkv0ff5c-notmuch-addrlookup-9.drv': 1 dependencies couldn't be built
error: build of '/nix/store/2mfyfkz94zrajxh55jyafr0pvkv0ff5c-notmuch-addrlookup-9.drv' failed

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 11, 2018

andir requested changes Feb 11, 2018

View reviewed changes

flokli force-pushed the notmuch-addrlookup branch from 29deef8 to 08b2055 Compare February 11, 2018 13:01

GrahamcOfBorg added 10.rebuild-darwin: 0 and removed 10.rebuild-darwin: 1-10 labels Feb 11, 2018

flokli force-pushed the notmuch-addrlookup branch from 08b2055 to b89aad4 Compare February 11, 2018 19:59

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 labels Feb 11, 2018

andir approved these changes Feb 12, 2018

View reviewed changes

Mic92 merged commit 8b5d7a5 into NixOS:master Feb 13, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

notmuch-addrlookup: 7 -> 9 #34833

notmuch-addrlookup: 7 -> 9 #34833

flokli commented Feb 11, 2018 •

edited

andir commented Feb 11, 2018

GrahamcOfBorg commented Feb 11, 2018

GrahamcOfBorg commented Feb 11, 2018

andir Feb 11, 2018

flokli Feb 11, 2018

GrahamcOfBorg commented Feb 11, 2018

andir commented Feb 11, 2018

GrahamcOfBorg commented Feb 11, 2018

GrahamcOfBorg commented Feb 11, 2018

GrahamcOfBorg commented Feb 11, 2018

flokli commented Feb 11, 2018

andir commented Feb 11, 2018

GrahamcOfBorg commented Feb 11, 2018

GrahamcOfBorg commented Feb 11, 2018

GrahamcOfBorg commented Feb 11, 2018

notmuch-addrlookup: 7 -> 9 #34833

notmuch-addrlookup: 7 -> 9 #34833

Conversation

flokli commented Feb 11, 2018 • edited

Motivation for this change

Things done

andir commented Feb 11, 2018

GrahamcOfBorg commented Feb 11, 2018

GrahamcOfBorg commented Feb 11, 2018

andir Feb 11, 2018

Choose a reason for hiding this comment

flokli Feb 11, 2018

Choose a reason for hiding this comment

GrahamcOfBorg commented Feb 11, 2018

andir commented Feb 11, 2018

GrahamcOfBorg commented Feb 11, 2018

GrahamcOfBorg commented Feb 11, 2018

GrahamcOfBorg commented Feb 11, 2018

flokli commented Feb 11, 2018

andir commented Feb 11, 2018

GrahamcOfBorg commented Feb 11, 2018

GrahamcOfBorg commented Feb 11, 2018

GrahamcOfBorg commented Feb 11, 2018

flokli commented Feb 11, 2018 •

edited