VMs module (see RFC 0012) #34823
Closed
VMs module (see RFC 0012) #34823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will likely never happen. So closing it, and when I get a chance to un-bitrot all of this and actually use it myself I'll just put it up on NUR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the way of RFC 0012 has to not move forward, and given how long time I've lost trying to push things forward, I am currently giving up pushing for upstreaming this module.
So here is a dump of my VMs branch. It was based on an older commit, but I rebased it on the tip a few days ago.
It should work and do almost everything the RFC states (except for not changing IP assignment when adding/removing VMs), if I remember correctly. Then, it's been almost a year since I last touched this code, so I guess my memories may not be exact. In particular, if I can trust the TODO's I setup for myself, there were still questions about how to properly handle DNS configuration when the host has a dynamic IP.
Anyway, this has bitrotten enough that I don't even remember the feature set it covered... :( so I'm just opening this PR so that anyone motivated enough could take over.
Good bye, little PR, and thanks again for the fish. I'll now concentrate on upstreaming other things, like package updates. :) (and don't hesitate to close this PR if you don't believe it brings any good)