Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests: add simple dockerTools test #34952

Merged
merged 1 commit into from Feb 14, 2018
Merged

nixos/tests: add simple dockerTools test #34952

merged 1 commit into from Feb 14, 2018

Conversation

Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Feb 14, 2018 •
edited

A simple test to check whether dockerTools generates valid images.

@Profpatsch
Copy link
Member Author

@GrahamcOfBorg test docker-tools

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

docker: exit status 1
syncing
docker: running command: sync
docker: exit status 0
test script finished in 18.37s
cleaning up
killing docker (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/miv9mxarahplpa2pg7c9i5b8vaiw345h-vm-test-run-docker-tools

@adisbladis
Copy link
Member

@GrahamcOfBorg test docker-tools

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

docker: running command: sync
docker# [   15.600959] dhcpcd[818]: docker0: deleting address fe80::42:52ff:fee4:1c09
docker# [   15.602702] dhcpcd[818]: veth4267e96: removing interface
docker: exit status 0
test script finished in 16.64s
cleaning up
killing docker (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-docker-tools.drv-0/vde1.ctl': Directory not empty
/nix/store/8v85mvffymyk7as0r67fm8fh60pr7nif-vm-test-run-docker-tools

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

docker: exit status 1
syncing
docker: running command: sync
docker: exit status 0
test script finished in 31.55s
cleaning up
killing docker (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/8yaf6l493q91z3j27adyrab110hmv9ia-vm-test-run-docker-tools

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

docker: exit status 1
syncing
docker: running command: sync
docker: exit status 0
test script finished in 30.31s
cleaning up
killing docker (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/2f3ahmrxg5lpyiqs7rixg9dng2n625s4-vm-test-run-docker-tools

@Profpatsch
Copy link
Member Author

Yay!

adisbladis
adisbladis reviewed Feb 14, 2018
View reviewed changes
nixos/release.nix Outdated
@@ -244,6 +244,7 @@ in rec {
tests.containers-macvlans = callTest tests/containers-macvlans.nix {};
tests.couchdb = callTest tests/couchdb.nix {};
tests.docker = callTestOnTheseSystems ["x86_64-linux"] tests/docker.nix {};
tests.docker-tools = callTest tests/docker-tools.nix {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we perhaps do tests.docker-tools = callTestOnTheseSystems ["x86_64-linux"] tests/docker-tools.nix {}; or tests.docker-tools = callTestOnTheseSystems lib.platforms.linux tests/docker-tools.nix {};

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To save on testing resources?

@Profpatsch
Copy link
Member Author

@GrahamcOfBorg test docker-tools

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

docker: exit status 1
syncing
docker: running command: sync
docker: exit status 0
test script finished in 16.64s
cleaning up
killing docker (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/lhzac3bkd2jji8f4rhry2rqkn6bnwvah-vm-test-run-docker-tools

@Profpatsch
Copy link
Member Author

Looks like ofborg doesn’t look at the callForTheseSystems flags when evaluating tests.

@Profpatsch Profpatsch merged commit 1545f90 into NixOS:master Feb 14, 2018
@Profpatsch Profpatsch mentioned this pull request Feb 14, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Profpatsch @GrahamcOfBorg @adisbladis