Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makeDesktopItem: genericName is not mandatory #35652

Closed
wants to merge 1 commit into from
Closed

makeDesktopItem: genericName is not mandatory #35652

wants to merge 1 commit into from

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Fixes #20624

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg closed this Feb 26, 2018
@peterhoeg
Copy link
Member Author

Ignore this. Sorry for the noise.

@peterhoeg peterhoeg deleted the f/di branch February 26, 2018 06:26
@peterhoeg peterhoeg restored the f/di branch February 26, 2018 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@peterhoeg