Add a check function for the EBS resource. #877
Conversation
nixops/resources/ebs_volume.py
Outdated
| def check(self): | ||
| volume = nixops.ec2_utils.get_volume_by_id(self.connect(self.region), self.volume_id) | ||
| if volume is None: | ||
| self.state = self.MISSING |
There was a problem hiding this comment.
we probably need a warning that the volume is no longer available here as well.
There was a problem hiding this comment.
Well, the disks check doesn't include notes like the machine one. But after updating the volume state, the check table show it as missing
Machines state:
+---------+--------+-----+-----------+----------+----------------+----------------------------------------+------------------------------------------------------------+
| Name | Exists | Up | Reachable | Disks OK | Load avg. | Units | Notes |
+---------+--------+-----+-----------+----------+----------------+----------------------------------------+------------------------------------------------------------+
| machine | Yes | Yes | Yes | No | 0.00 0.00 0.00 | proc-sys-fs-binfmt_misc.mount [failed] | volume ‘vol-096cbe0647ee88eae’ not attached to ‘/dev/xvdf’ |
| | | | | | | | volume ‘vol-096cbe0647ee88eae’ no longer exists |
+---------+--------+-----+-----------+----------+----------------+----------------------------------------+------------------------------------------------------------+
Non machines resources state:
+--------------------+--------+
| Name | Exists |
+--------------------+--------+
| data_volume | No |
| my-key-pair | Yes |
| ssh-security-group | Yes |
+--------------------+--------+
The only thing that I can add is a message like this
data_volume.......> Volume VOLUME_ID is missing!
Before the check tables
There was a problem hiding this comment.
I see, yeah seems the existent warnings are fine already.
nixops/resources/ebs_volume.py
Outdated
| @@ -141,6 +141,10 @@ def create(self, defn, check, allow_reboot, allow_recreate): | |||
| states=['available', 'in-use']) | |||
| self.state = self.UP | |||
|
|
|||
| def check(self): | |||
There was a problem hiding this comment.
hm isn't the method name _check ?
There was a problem hiding this comment.
nevermind, checked again, this should work as well.
nixops/backends/ec2.py
Outdated
| @@ -506,6 +506,8 @@ def create_after(self, resources, defn): | |||
|
|
|||
| def attach_volume(self, device, volume_id): | |||
| volume = nixops.ec2_utils.get_volume_by_id(self.connect(), volume_id) | |||
| if not volume: | |||
| raise Exception("volume {0} doesn't exist".format(volume_id)) | |||
There was a problem hiding this comment.
Maybe you can suggest running nixops check here to reconcile the state with the real-world state.
|
Ping @rbvermaa |
If missing the volume will be marked as such, after a check
operation. Also show more meaningful error message when a volume
disappear. This fix #876.