New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
udisks2: 2.1.6 → 2.7.6 #35551
udisks2: 2.1.6 → 2.7.6 #35551
Conversation
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
a0d6329
to
738eabd
Compare
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
@flokli Your commit worked great, except that you forgot to add We will need to carefully inspect if we caught all the offenders, including |
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Oh wow, the missing I quickly skimmed over Whats still missing is other parts in which
Those could simply added to the path. I'm still not sure on whether to prefer patching via There's also src/plugins/s390.c with hardcoded paths (filed upstream PR at storaged-project/libblockdev#326). |
Success on x86_64-linux (full log) Partial log (click to expand)
|
I have had my own share of problems with wrappers so my perspective is little skewed. I agree that it is cleaner than the The optimal solution would be changing each individual executable in the source code to absolute path but of course that is laborious, and unless udisk calls the executables repeatedly, getting rid of Maybe we could make the paths |
@jtojnar, while you are at it, could you include storaged-project/udisks@f639f67 and storaged-project/udisks@293aa9b in the systemd service specification of the matching udisks2 module? Thank you. |
I will not have time to finish this anytime soon. Anyone want to take this over? |
This works (on top of recent staging changes) w/musl, with the following change: Which can probably be reduced to just building |
That's included in |
Continued in #41723 , closing. |
supersedes NixOS#35551 closes NixOS#34999 /cc NixOS#38382
Motivation for this change
Closes: #34999
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)