Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avro-c: init at 1.8.2 #35658

Merged
merged 3 commits into from Feb 26, 2018
Merged

avro-c: init at 1.8.2 #35658

merged 3 commits into from Feb 26, 2018

Conversation

lblasc
Copy link
Contributor

@lblasc lblasc commented Feb 26, 2018

Motivation for this change

Add C avro bindings.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lblasc
Copy link
Contributor Author

lblasc commented Feb 26, 2018

@GrahamcOfBorg build avro-c

1 similar comment
@Mic92
Copy link
Member

Mic92 commented Feb 26, 2018

@GrahamcOfBorg build avro-c

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:39 (message):
  Cannot determine Avro version number


-- Configuring incomplete, errors occurred!
See also "/build/avro-c-1.8.2/build/CMakeFiles/CMakeOutput.log".
builder for '/nix/store/ypzvdzfw7gjaxxvg13h47xn35izcz3mp-avro-c-1.8.2.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/ypzvdzfw7gjaxxvg13h47xn35izcz3mp-avro-c-1.8.2.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:39 (message):
  Cannot determine Avro version number


-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-avro-c-1.8.2.drv-0/avro-c-1.8.2/build/CMakeFiles/CMakeOutput.log".
builder for ‘/nix/store/7h74ahw02vhwzrf1g10hk014j1jx6qqy-avro-c-1.8.2.drv’ failed with exit code 1
error: build of ‘/nix/store/7h74ahw02vhwzrf1g10hk014j1jx6qqy-avro-c-1.8.2.drv’ failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

-- Installing: /nix/store/6q14zqr83k24c9v52w7jji8vlr0amprs-avro-c-1.8.2/lib/pkgconfig/avro-c.pc
-- Installing: /nix/store/6q14zqr83k24c9v52w7jji8vlr0amprs-avro-c-1.8.2/bin/avrocat
-- Installing: /nix/store/6q14zqr83k24c9v52w7jji8vlr0amprs-avro-c-1.8.2/bin/avroappend
-- Installing: /nix/store/6q14zqr83k24c9v52w7jji8vlr0amprs-avro-c-1.8.2/bin/avropipe
-- Installing: /nix/store/6q14zqr83k24c9v52w7jji8vlr0amprs-avro-c-1.8.2/bin/avromod
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/6q14zqr83k24c9v52w7jji8vlr0amprs-avro-c-1.8.2/lib  /nix/store/6q14zqr83k24c9v52w7jji8vlr0amprs-avro-c-1.8.2/bin
patching script interpreter paths in /nix/store/6q14zqr83k24c9v52w7jji8vlr0amprs-avro-c-1.8.2
/nix/store/6q14zqr83k24c9v52w7jji8vlr0amprs-avro-c-1.8.2

@Mic92
Copy link
Member

Mic92 commented Feb 26, 2018

I suppose you have to patch shebangs before in postPatch phase using patchShebangs .
https://github.com/apache/avro/blob/master/lang/c/version.sh#L1

Mic92
Mic92 reviewed Feb 26, 2018
View reviewed changes
pkgs/development/libraries/avro-c/default.nix Outdated

patchPhase = ''
substituteInPlace version.sh \
--replace /bin/bash "$bash/bin/bash"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah weird, you already did this.

@Mic92
Copy link
Member

Mic92 commented Feb 26, 2018

@GrahamcOfBorg build avro-c

Mic92
Mic92 reviewed Feb 26, 2018
View reviewed changes
pkgs/development/libraries/avro-c/default.nix Outdated
substituteInPlace version.sh \
--replace /bin/bash "$bash/bin/bash"
postPatch = ''
patchShebangs .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the build for me.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/559ihh1ll4hary7p12w2fb05ym72il01-avro-c-1.8.2/bin/avropipe
shrinking /nix/store/559ihh1ll4hary7p12w2fb05ym72il01-avro-c-1.8.2/bin/avrocat
shrinking /nix/store/559ihh1ll4hary7p12w2fb05ym72il01-avro-c-1.8.2/bin/avromod
shrinking /nix/store/559ihh1ll4hary7p12w2fb05ym72il01-avro-c-1.8.2/bin/avroappend
shrinking /nix/store/559ihh1ll4hary7p12w2fb05ym72il01-avro-c-1.8.2/lib/libavro.so.23.0.0
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/559ihh1ll4hary7p12w2fb05ym72il01-avro-c-1.8.2/lib  /nix/store/559ihh1ll4hary7p12w2fb05ym72il01-avro-c-1.8.2/bin 
patching script interpreter paths in /nix/store/559ihh1ll4hary7p12w2fb05ym72il01-avro-c-1.8.2
checking for references to /tmp/nix-build-avro-c-1.8.2.drv-0 in /nix/store/559ihh1ll4hary7p12w2fb05ym72il01-avro-c-1.8.2...
/nix/store/559ihh1ll4hary7p12w2fb05ym72il01-avro-c-1.8.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/gfg6i3hxdpwlak1mkfj8p6f6m22p9h5y-avro-c-1.8.2/bin/avromod
shrinking /nix/store/gfg6i3hxdpwlak1mkfj8p6f6m22p9h5y-avro-c-1.8.2/bin/avropipe
shrinking /nix/store/gfg6i3hxdpwlak1mkfj8p6f6m22p9h5y-avro-c-1.8.2/bin/avroappend
shrinking /nix/store/gfg6i3hxdpwlak1mkfj8p6f6m22p9h5y-avro-c-1.8.2/bin/avrocat
shrinking /nix/store/gfg6i3hxdpwlak1mkfj8p6f6m22p9h5y-avro-c-1.8.2/lib/libavro.so.23.0.0
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/gfg6i3hxdpwlak1mkfj8p6f6m22p9h5y-avro-c-1.8.2/lib  /nix/store/gfg6i3hxdpwlak1mkfj8p6f6m22p9h5y-avro-c-1.8.2/bin
patching script interpreter paths in /nix/store/gfg6i3hxdpwlak1mkfj8p6f6m22p9h5y-avro-c-1.8.2
checking for references to /build in /nix/store/gfg6i3hxdpwlak1mkfj8p6f6m22p9h5y-avro-c-1.8.2...
/nix/store/gfg6i3hxdpwlak1mkfj8p6f6m22p9h5y-avro-c-1.8.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

-- Installing: /nix/store/q3mq5wq00bzzinwxj9wz9rjmq10iwlks-avro-c-1.8.2/lib/pkgconfig/avro-c.pc
-- Installing: /nix/store/q3mq5wq00bzzinwxj9wz9rjmq10iwlks-avro-c-1.8.2/bin/avrocat
-- Installing: /nix/store/q3mq5wq00bzzinwxj9wz9rjmq10iwlks-avro-c-1.8.2/bin/avroappend
-- Installing: /nix/store/q3mq5wq00bzzinwxj9wz9rjmq10iwlks-avro-c-1.8.2/bin/avropipe
-- Installing: /nix/store/q3mq5wq00bzzinwxj9wz9rjmq10iwlks-avro-c-1.8.2/bin/avromod
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/q3mq5wq00bzzinwxj9wz9rjmq10iwlks-avro-c-1.8.2/lib  /nix/store/q3mq5wq00bzzinwxj9wz9rjmq10iwlks-avro-c-1.8.2/bin
patching script interpreter paths in /nix/store/q3mq5wq00bzzinwxj9wz9rjmq10iwlks-avro-c-1.8.2
/nix/store/q3mq5wq00bzzinwxj9wz9rjmq10iwlks-avro-c-1.8.2

@Mic92 Mic92 merged commit 9bf653c into NixOS:master Feb 26, 2018
@lblasc lblasc deleted the avro-c branch February 27, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lblasc @Mic92 @GrahamcOfBorg