luaposix: 33.4.0 -> 34.0.4, add dependencies #35581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vyp please take a look, thanks! |
|
@Mic92 maybe you can take a look? Thanks! |
|
@GrahamcOfBorg build luajitPackages.bit32 lua52Packages.bit32 lua51Packages.bit32 lua51Packages.luaposix lua52Packages.luaposix luajitPackages.luaposix |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
It looks like darwin mixes multiple lua versions. |
|
@GrahamcOfBorg build lua52Packages.luaposix |
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Mic92
reviewed
Mar 9, 2018
pkgs/top-level/lua-packages.nix
Outdated
| }; | ||
|
|
||
| buildPhase = '' | ||
| cc -shared -I${lua}/include -Ic-api lbitlib.c -o bit32.so |
There was a problem hiding this comment.
Can you try to add lua to buildInputs instead?
|
@GrahamcOfBorg build lua52Packages.bit32 |
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
@GrahamcOfBorg build lua51Packages.bit32 |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
|
@GrahamcOfBorg build lua52Packages.bit32 |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
@GrahamcOfBorg build lua52Packages.luaposix |
|
Success on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
@GrahamcOfBorg build luajitPackages.bit32 lua52Packages.bit32 lua51Packages.bit32 lua51Packages.luaposix lua52Packages.luaposix luajitPackages.luaposix |
|
Success on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Mic92
reviewed
Mar 9, 2018
pkgs/top-level/lua-packages.nix
Outdated
| LUA="${lua}/bin/lua" \ | ||
| LUA_INCDIR="-I${lua}/include" \ | ||
| INST_LIBDIR="$out/lib/lua/${lua.luaversion}" \ | ||
| INST_LUADIR="$out/share/lua/${lua.luaversion}" |
There was a problem hiding this comment.
I was able to remove the last 4 lines here. Are they really necessary?
There was a problem hiding this comment.
I've got this options from rocks file https://github.com/luaposix/luaposix/blob/master/luaposix-git-1.rockspec#L33
It should work without it.
There was a problem hiding this comment.
mhm. Version should be there: https://github.com/luaposix/luaposix/blob/649454019dcc983eb6b398624e5b6c68d72f7808/lib/posix/version.lua.in
Mic92
reviewed
Mar 9, 2018
| }; | ||
|
|
||
| buildInputs = [ perl ]; | ||
| propagatedBuildInputs = [ std.normalize bit32 ]; |
There was a problem hiding this comment.
Seems like luaposix library doesn't check if running under lua5.2, it loads bit32 lib every time. I would leave it.
lblasc
commented
Mar 9, 2018
pkgs/top-level/lua-packages.nix
Outdated
| LUA="${lua}/bin/lua" \ | ||
| LUA_INCDIR="-I${lua}/include" \ | ||
| INST_LIBDIR="$out/lib/lua/${lua.luaversion}" \ | ||
| INST_LUADIR="$out/share/lua/${lua.luaversion}" |
There was a problem hiding this comment.
I've got this options from rocks file https://github.com/luaposix/luaposix/blob/master/luaposix-git-1.rockspec#L33
It should work without it.
|
I rebased everything in 13c8e01 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Refresh package and add new dependencies.
Thanks!
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)