Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dhcpcd: 6.11.5 -> 7.0.1 #35622

Merged
merged 1 commit into from Feb 26, 2018
Merged

dhcpcd: 6.11.5 -> 7.0.1 #35622

merged 1 commit into from Feb 26, 2018

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Feb 26, 2018

Semi-automatic update. These checks were performed:

  • built on NixOS
  • ran /nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1/bin/dhcpcd --help got 0 exit code
  • ran /nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1/bin/dhcpcd --version and found version 7.0.1
  • found 7.0.1 with grep in /nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1
  • found 7.0.1 in filename of file in /nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1

@ryantm
dhcpcd: 6.11.5 -> 7.0.1
7cc74d6 
Semi-automatic update. These checks were performed:

- built on NixOS
- ran `/nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1/bin/dhcpcd --help` got 0 exit code
- ran `/nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1/bin/dhcpcd --version` and found version 7.0.1
- found 7.0.1 with grep in /nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1
- found 7.0.1 in filename of file in /nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1
@ryantm
Copy link
Member Author

ryantm commented Feb 26, 2018

@GrahamcOfBorg build dhcpcd

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘dhcpcd-7.0.1’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/tools/networking/dhcpcd/default.nix:29 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/l5hjvl40psk1xxiaf0bnnhv75sl65j7f-dhcpcd-7.0.1/lib/dhcpcd/dev/udev.so
shrinking /nix/store/l5hjvl40psk1xxiaf0bnnhv75sl65j7f-dhcpcd-7.0.1/sbin/dhcpcd
gzipping man pages under /nix/store/l5hjvl40psk1xxiaf0bnnhv75sl65j7f-dhcpcd-7.0.1/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/l5hjvl40psk1xxiaf0bnnhv75sl65j7f-dhcpcd-7.0.1/lib  /nix/store/l5hjvl40psk1xxiaf0bnnhv75sl65j7f-dhcpcd-7.0.1/libexec  /nix/store/l5hjvl40psk1xxiaf0bnnhv75sl65j7f-dhcpcd-7.0.1/sbin
patching script interpreter paths in /nix/store/l5hjvl40psk1xxiaf0bnnhv75sl65j7f-dhcpcd-7.0.1
/nix/store/l5hjvl40psk1xxiaf0bnnhv75sl65j7f-dhcpcd-7.0.1/libexec/dhcpcd-run-hooks: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/l5hjvl40psk1xxiaf0bnnhv75sl65j7f-dhcpcd-7.0.1...
moving /nix/store/l5hjvl40psk1xxiaf0bnnhv75sl65j7f-dhcpcd-7.0.1/sbin/* to /nix/store/l5hjvl40psk1xxiaf0bnnhv75sl65j7f-dhcpcd-7.0.1/bin
/nix/store/l5hjvl40psk1xxiaf0bnnhv75sl65j7f-dhcpcd-7.0.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1/sbin/dhcpcd
shrinking /nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1/lib/dhcpcd/dev/udev.so
gzipping man pages under /nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1/lib  /nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1/libexec  /nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1/sbin 
patching script interpreter paths in /nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1
/nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1/libexec/dhcpcd-run-hooks: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-dhcpcd-7.0.1.drv-0 in /nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1...
moving /nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1/sbin/* to /nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1/bin
/nix/store/04mp6n1v5sgc62qwxpz1gfxv589cn76k-dhcpcd-7.0.1

@Mic92
Copy link
Member

Mic92 commented Feb 26, 2018

@GrahamcOfBorg test networking.scripted

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

@Mic92
Copy link
Member

Mic92 commented Feb 26, 2018

@GrahamcOfBorg test networking.scripted.dhcpSimple

@Mic92
Copy link
Member

Mic92 commented Feb 26, 2018

@GrahamcOfBorg test networking.scripted.dhcpOneIf

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

cleaning up
killing client (pid 595)
killing router (pid 605)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-SimpleDHCP-Networking-Scripted.drv-0/vde3.ctl': Directory not empty
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-SimpleDHCP-Networking-Scripted.drv-0/vde1.ctl': Directory not empty
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-SimpleDHCP-Networking-Scripted.drv-0/vde2.ctl': Directory not empty
/nix/store/jpp188a4igjvnpg5gq4s4y4phm7s221i-vm-test-run-SimpleDHCP-Networking-Scripted

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

cleaning up
killing router (pid 595)
killing client (pid 606)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: EOF on stdin, cleaning up and exitingvde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-OneInterfaceDHCP-Networking-Scripted.drv-0/vde3.ctl': Directory not empty

vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-OneInterfaceDHCP-Networking-Scripted.drv-0/vde2.ctl': Directory not empty
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-OneInterfaceDHCP-Networking-Scripted.drv-0/vde1.ctl': Directory not empty
/nix/store/s3lg0kji40i0x00da9n8n425lxdy5i01-vm-test-run-OneInterfaceDHCP-Networking-Scripted

@Mic92 Mic92 merged commit ea29d6a into NixOS:master Feb 26, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

cleaning up
killing router (pid 629)
killing client (pid 641)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde3.ctl': Directory not emptyvde_switch:
Could not remove ctl dir '/build/vde2.ctl': Directory not empty
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/9df3lb70ikig7m28ahhcfz5w6pir53s2-vm-test-run-OneInterfaceDHCP-Networking-Scripted

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

cleaning up
killing client (pid 629)
killing router (pid 641)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde3.ctl': Directory not empty
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
vde_switch: Could not remove ctl dir '/build/vde2.ctl': Directory not empty
/nix/store/bj9hd8gr3nlxc5dgqfxj5cl5kra34q94-vm-test-run-SimpleDHCP-Networking-Scripted

@dtzWill
Copy link
Member

dtzWill commented Feb 26, 2018 •
edited

Bump to dhcpcd 7 was previously reverted: #33527, has that been fixed?

@GrahamcOfBorg test networking.scripted.macvlan

@dtzWill
Copy link
Member

dtzWill commented Feb 26, 2018

Eep, reading the issue it does appear this was fixed. Just trying to help ensure everything is good, carry on! 👍

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

killing router (pid 598)
killing client (pid 609)
vde_switch: vde_switch: EOF on stdin, cleaning up and exiting
EOF on stdin, cleaning up and exiting
vde_switch: vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-MACVLAN-Networking-Scripted.drv-0/vde3.ctl': Directory not empty
Could not remove ctl dir '/tmp/nix-build-vm-test-run-MACVLAN-Networking-Scripted.drv-0/vde2.ctl': Directory not empty
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-MACVLAN-Networking-Scripted.drv-0/vde1.ctl': Directory not empty
builder for ‘/nix/store/dxmpr505x3cs1whgaakxqvipfggfip4k-vm-test-run-MACVLAN-Networking-Scripted.drv’ failed with exit code 4
error: build of ‘/nix/store/dxmpr505x3cs1whgaakxqvipfggfip4k-vm-test-run-MACVLAN-Networking-Scripted.drv’ failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

router: exit status 1
router: running command: ping -c 1 192.168.1.3
router: exit status 1
router: running command: ping -c 1 192.168.1.3
router: exit status 1
router: running command: ping -c 1 192.168.1.3
router: exit status 1
router: running command: ping -c 1 192.168.1.3
building of '/nix/store/h3w5244bm2fiw3dp06ssfwr4gj1g6sw8-vm-test-run-MACVLAN-Networking-Scripted.drv' timed out after 3600 seconds
�[31;1merror:�[0m build of '/nix/store/h3w5244bm2fiw3dp06ssfwr4gj1g6sw8-vm-test-run-MACVLAN-Networking-Scripted.drv' failed

@dtzWill
Copy link
Member

dtzWill commented Feb 27, 2018

😟

That doesn't seem.. expected? 😇

@Mic92
Copy link
Member

Mic92 commented Feb 27, 2018

Weird it gets inet 10.0.2.15/24 brd 10.0.2.255 scope global noprefixroute eth1 in the test instead of the 192.x.x.x subnet.

@Mic92
Copy link
Member

Mic92 commented Feb 27, 2018

This is ip assigned by qemu as it seems.

@Mic92
Copy link
Member

Mic92 commented Feb 27, 2018

Probably dhcpcd waits less time then in older releases.

@Mic92
Copy link
Member

Mic92 commented Feb 27, 2018

Also if I revert the dhcpcd update, the test fails because the wrong ip address is assigned.

@Mic92
Copy link
Member

Mic92 commented Feb 27, 2018

Same happens with networkd.

@vcunat
Copy link
Member

vcunat commented Mar 1, 2018

The test is blocking the channel. What I "blindly" tried:

  • it fails on 7cc74d6 and works on the parent;
  • current master 1242214 fails but works if I add revert of 7cc74d6.

If noone knows an explanation soon (today), I'd revert for now, again.

@vcunat
Copy link
Member

vcunat commented Mar 1, 2018

Also /cc @fpletz due to the last update attempt.

@Mic92
Copy link
Member

Mic92 commented Mar 1, 2018 •
edited

@vcunat unless you know how to prevent qemu from playing a rogue dhcp server (by parameters),
I don't know how to solve this. The revert maybe should also add a reference to the failing test.
Otherwise the next person will do the same mistake and upgrade dhcpcd.

globin added a commit that referenced this pull request Mar 2, 2018
@globin
Revert "dhcpcd: 6.11.5 -> 7.0.1"
a8d3aa5 
This reverts commit 7cc74d6.

See discussion in #35622

cc @vcunat @Mic92 @fpletz
@vcunat
Copy link
Member

vcunat commented Mar 2, 2018

I gather the problem is in the test (most likely), though I'm not very happy with simply disabling the test either.

@Mic92
Copy link
Member

Mic92 commented Mar 2, 2018

Now dhcpcd was reverted instead.

@ryantm ryantm deleted the auto-update/dhcpcd-6.11.5-to-7.0.1 branch March 14, 2018 19:18
@ryantm ryantm mentioned this pull request Mar 16, 2018
Closed
@xeji xeji mentioned this pull request Sep 1, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ryantm @GrahamcOfBorg @Mic92 @dtzWill @vcunat