Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flexget: 2.10.82 -> 2.12.8 #35557

Merged
merged 2 commits into from Mar 17, 2018
Merged

flexget: 2.10.82 -> 2.12.8 #35557

merged 2 commits into from Mar 17, 2018

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 25, 2018

Motivation for this change

Fix #34785

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s)
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution of all binary files
  • Fits CONTRIBUTING.md.
Notes
  • The package distributed on PyPi doesn't seem to include the library needed to run tests; so you have to get it with FetchFromGitHub if you want to try it.
  • There are 409 test failures. I don't know it they are just broken or it's NixOS' fault.
  • I haven't tried flexget besides running the two executables. I have never used this software: some user should maybe try this.

cc @domenkozar @tari

}:

assert delugeSupport -> deluge != null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so unless I do an override the assertion will break? Wouldn’t it be better to set a sensitive default (no deluge support or deuge not null by default) to make a setup easier?

Copy link
Contributor Author

@rnhmjoj rnhmjoj Feb 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it won't break. deluge should always be provided, unless someone explicitly does so but in that case he would have presumably disabled support. The assertion fails only when the package is called without deluge but delugeSupport is wanted. It's a common pattern used throughout nixpkgs to implement optional features.

and not test_non_ascii"
'';
# ~400 failures
doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just out of interest: how far did you get? I tried to fix that once, but failed after some time...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't really tried because there were way too many. And I'm not entirely convinced the failures are all about sandboxing.

, transmission
, deluge
, config
{ lib, config, python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config isn’t needed anymore, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, removed.

@Ma27
Copy link
Member

Ma27 commented Feb 27, 2018

@rnhmjoj you’re right about the deluge assertion, sorry about that...

IIRC hyper_ch from the #nixos IRC (don’t know his GitHub name) was interested in this, I can ping him tonight as I’m currently on my phone...

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 27, 2018

@Ma27 Ok, thank you.

@sjau
Copy link

sjau commented Feb 28, 2018

Unfortunately it doesn't seem to work:

2018-02-28 19:26 WARNING  apscheduler.scheduler                 Error getting due jobs from job store u'default': (sqlite3.OperationalError) no such table: apscheduler_jobs [SQL: u'SELECT apscheduler_jobs.id, apscheduler_jobs.job_state \nFROM apscheduler_jobs \nWHERE apscheduler_jobs.next_run_time <= ? ORDER BY apscheduler_jobs.next_run_time'] [parameters: (1519842395.895253,)] (Background on this error at: http://sqlalche.me/e/e3q8)
2018-02-28 19:26 WARNING  apscheduler.scheduler                 Error getting due jobs from job store u'default': (sqlite3.OperationalError) no such table: apscheduler_jobs [SQL: u'SELECT apscheduler_jobs.id, apscheduler_jobs.job_state \nFROM apscheduler_jobs \nWHERE apscheduler_jobs.next_run_time <= ? ORDER BY apscheduler_jobs.next_run_time'] [parameters: (1519842405.896621,)] (Background on this error at: http://sqlalche.me/e/e3q8)
2018-02-28 19:26 WARNING  apscheduler.scheduler                 Error getting due jobs from job store u'default': (sqlite3.OperationalError) no such table: apscheduler_jobs [SQL: u'SELECT apscheduler_jobs.id, apscheduler_jobs.job_state \nFROM apscheduler_jobs \nWHERE apscheduler_jobs.next_run_time <= ? ORDER BY apscheduler_jobs.next_run_time'] [parameters: (1519842415.898658,)] (Background on this error at: http://sqlalche.me/e/e3q8)
2018-02-28 19:27 WARNING  apscheduler.scheduler                 Error getting due jobs from job store u'default': (sqlite3.OperationalError) no such table: apscheduler_jobs [SQL: u'SELECT apscheduler_jobs.id, apscheduler_jobs.job_state \nFROM apscheduler_jobs \nWHERE apscheduler_jobs.next_run_time <= ? ORDER BY apscheduler_jobs.next_run_time'] [parameters: (1519842425.900076,)] (Background on this error at: http://sqlalche.me/e/e3q8)
2018-02-28 19:27 WARNING  apscheduler.scheduler                 Error getting due jobs from job store u'default': (sqlite3.OperationalError) no such table: apscheduler_jobs [SQL: u'SELECT apscheduler_jobs.id, apscheduler_jobs.job_state \nFROM apscheduler_jobs \nWHERE apscheduler_jobs.next_run_time <= ? ORDER BY apscheduler_jobs.next_run_time'] [parameters: (1519842435.902832,)] (Background on this error at: http://sqlalche.me/e/e3q8)
2018-02-28 19:27 WARNING  apscheduler.scheduler                 Error getting due jobs from job store u'default': (sqlite3.OperationalError) no such table: apscheduler_jobs [SQL: u'SELECT apscheduler_jobs.id, apscheduler_jobs.job_state \nFROM apscheduler_jobs \nWHERE apscheduler_jobs.next_run_time <= ? ORDER BY apscheduler_jobs.next_run_time'] [parameters: (1519842445.906124,)] (Background on this error at: http://sqlalche.me/e/e3q8)
2018-02-28 19:27 WARNING  apscheduler.scheduler                 Error getting due jobs from job store u'default': (sqlite3.OperationalError) no such table: apscheduler_jobs [SQL: u'SELECT apscheduler_jobs.id, apscheduler_jobs.job_state \nFROM apscheduler_jobs \nWHERE apscheduler_jobs.next_run_time <= ? ORDER BY apscheduler_jobs.next_run_time'] [parameters: (1519842455.908281,)] (Background on this error at: http://sqlalche.me/e/e3q8)

I started with an empty sqlite db and I just get that.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 28, 2018

Uhm, so maybe the version constaints were really necessary.

maintainers = with lib.maintainers; [ domenkozar tari ];
broken = true; # as of 2018-02-09
license = licenses.mit;
maintainers = with maintainers; [ domenkozar tari ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you use flexget on a regular base?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, never in fact. I have been trying to fix packages reported in #34775

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some python dependencies should be be locked down with pypi2nix or so?

@tari
Copy link
Contributor

tari commented Mar 1, 2018

The package distributed on PyPi doesn't seem to include the library needed to run tests; so you have to get it with FetchFromGitHub if you want to try it.

This is why I didn't switch to fetching from PyPi before- plus there doesn't seem to be any real benefit to getting it from PyPi over github, since we can still fetch by version number.


I would probably avoid unpinning every dependency, since it makes it harder to tell what's probably a compatible version in Nix and what needs to be upgraded (or have an old version packaged).

My attempt at 2.12.0 is at tari@a5d0126 for reference. It built but there were a lot of test failures that I didn't want to try to debug, nor did I try running the output (so it might fail in the same way as this one).

Looking at upstream changes between 2.12.0 (per my attempt) and 2.12.8, the only important thing to us appears to be upgrades to rebulk (0.9) and guessit (2.1.4)- we'll probably need to upgrade both of those, since guessit tends to be very sensitive to rebulk's behavior.

@Mic92
Copy link
Member

Mic92 commented Mar 1, 2018

@tari Are you using flexget at least or plan so? At the moment I only see people voluntary fixing flexget.
I don't want people burning out over a package that nobody wants to use actually.

@tari
Copy link
Contributor

tari commented Mar 1, 2018

I currently use it, so it's useful to me if it works (but if it doesn't I'll find a replacement- I don't actually use many of its features).

@sjau
Copy link

sjau commented Mar 1, 2018

I use it as well... but is there really a replacement for flexget?

@Mic92
Copy link
Member

Mic92 commented Mar 1, 2018

@tari @sjau do you think you could maintain flexget or bring in a state, where it know longer break, whenever we upgrade python packages?

@sjau
Copy link

sjau commented Mar 1, 2018

Python hates me... I still have nightmares about when I try to package ocrmypdf

@sjau
Copy link

sjau commented Mar 3, 2018

I tried with 2.13.0 but it fails again... problematic seems to be sqlalchemy which we only have in v. 1.2.3 and it should be 1.1.17

howto get sqlalchemy 1.1.17 ?

@Ma27
Copy link
Member

Ma27 commented Mar 3, 2018

howto get sqlalchemy 1.1.17 ?

I assume that the easiest way would be to override our sqlalchemy package for flexget.
Otherwise we'd have to use something like pypi2nix, but this has been discussed already: #34589 (comment)

@sjau
Copy link

sjau commented Mar 3, 2018

So, I tried now with this expression:

{ lib
, fetchFromGitHub
, python
, transmission
, deluge
, config
}:

with python.pkgs;

let

  sqlalchemy = callPackage (builtins.fetchurl "https://raw.githubusercontent.com/sjau/nix-expressions/master/sqlalchemy-1.1.10.nix") {};

in

buildPythonApplication rec {
  version = "2.13.0";
  name = "FlexGet-${version}";

  src = fetchFromGitHub {
    owner = "Flexget";
    repo = "Flexget";
    rev = version;
    sha256 = "014zfqr62q505sf3z7kfdqwyb1rfqw976b2fzcmddfh7q2i2nw3i";
  };

  doCheck = false;
  # test_regexp requires that HOME exist, test_filesystem requires a
  # unicode-capable filesystem (and setting LC_ALL doesn't work).
  # setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
  postPatch = ''
    substituteInPlace requirements.txt \
      --replace "chardet==3.0.3" "chardet" \
      --replace "rebulk==0.9.0" "rebulk" \
      --replace "cherrypy==10.2.2" "cherrypy" \
      --replace "portend==1.8" "portend" \
      --replace "sqlalchemy==1.1.10" "sqlalchemy" \
      --replace "zxcvbn-python==4.4.15" "zxcvbn-python" \
      --replace "flask-cors==3.0.2" "flask-cors" \
      --replace "certifi==2017.4.17" "certifi" \
      --replace "apscheduler==3.5.0" "apscheduler" \
      --replace "path.py==10.3.1" "path.py" \
      --replace "tempora==1.8" "tempora" \
      --replace "cheroot==5.5.0" "cheroot" \
      --replace "six==1.10.0" "six" \
      --replace "aniso8601==1.2.1" "aniso8601" \
      --replace "flask==0.12.2" "flask" \
      --replace "guessit==2.1.4" "guessit" \
      --replace "werkzeug==0.12.2" "werkzeug" \
      --replace "pytz==2017.2" "pytz" \
      --replace "tzlocal==1.4" "tzlocal" \
      --replace "html5lib==0.999999999" "html5lib" \
      --replace "jinja2==2.9.6" "jinja2" \
      --replace "urllib3==1.21.1" "urllib3" \
      --replace "plumbum==1.6.3" "plumbum" \
      --replace "idna==2.5" "idna" \
      --replace "requests==2.16.5" "requests"
  '';

  checkPhase = ''
    export HOME=.
    py.test --disable-pytest-warnings -k "not test_quality_failures \
                                          and not test_group_quality \
                                          and not crash_report \
                                          and not test_multi_episode \
                                          and not test_double_episodes \
                                          and not test_inject_force \
                                          and not test_double_prefered \
                                          and not test_double \
                                          and not test_non_ascii"
  '';

  buildInputs = [ pytest mock vcrpy pytest-catchlog boto3 ];
  propagatedBuildInputs = [
    feedparser sqlalchemy pyyaml chardet
    beautifulsoup4 html5lib PyRSS2Gen pynzb
    rpyc jinja2 jsonschema requests dateutil
    pathpy guessit_2_0 APScheduler
    terminaltables colorclass
    cherrypy flask flask-restful flask-restplus
    flask-compress flask_login flask-cors
    pyparsing safe future zxcvbn-python
    werkzeug tempora cheroot rebulk portend
    aniso8601 babelfish certifi click futures idna itsdangerous markupsafe plumbum pytz six tzlocal urllib3 webencodings werkzeug zxcvbn-python
  ] ++ lib.optional (pythonOlder "3.4") pathlib
    # enable deluge and transmission plugin support, if they're installed
    ++ lib.optional (config.deluge or false) deluge
    ++ lib.optional (transmission != null) transmissionrpc;

  meta = {
    homepage = https://flexget.com/;
    description = "Multipurpose automation tool for content like torrents";
    license = lib.licenses.mit;
    maintainers = with lib.maintainers; [ domenkozar tari ];
#    broken = true; # as of 2018-02-09
  };
}

But still an issue with the db

2018-03-03 15:06 CRITICAL task          tv_feeds_hq     BUG: Unhandled error in plugin series: (sqlite3.OperationalError) too many SQL variables [SQL: u'SELECT series.name AS series_name, series.name_lower AS series_name_lower, series.id AS series_id, series.identified_by AS series_identified_by, series.begin_episode_id AS series_begin_episode_id \nFROM series \nWHERE series.name_lower IN (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)'] [parameters: (u'\u0113ldlive', u'zero hour', u'z x ignition', u'z nation', u'yuusha ni narenakatta ore wa shibushibu shuushoku wo ketsui shimashita', u'young sheldon', u'youkoso jitsuryoku shijou shugi no kyoushitsu e', u'youkai apartment no yuuga na nichijou', u'youji senki', u'yatterman night', u'xiii the series', u'xiii', u'world trigger', u'wizard barristers', u'witch craft works', u'wisdom of the crowd', u'will', u'white collar', u'when supernatural battles became commonplace', u'westworld', u'welcome to sweden', u'wayward pines', u'war and peace 2016', u'wanted 2016', u'waco', u'vividred operation', u'vikings', u'victoria', u'vivid strike!', u'versailles 2015', u'
[....]

@sjau
Copy link

sjau commented Mar 3, 2018

Using now SQLAlchemy 1.1.10 and reverting back to flexet 2.12.11 I still get those crashes.... but it seems to work... it did download some torrent files.

@sjau
Copy link

sjau commented Mar 4, 2018

Ok, this expression works. Tested it now, however there's a few drawbacks:

  1. no more than 500 show entries can be used (it's a problem on flexget side it seems)
  2. very likely the current sqlite dbs need to removed

What did I test?

Just basic functionality... adding a list of tv shows and auto-fetch them from rss feeds and store them in the designated folder(s).

I didn't test any direct interaction with transmission or deluge... neither tried to fetch from nzbs.

{ lib
, fetchFromGitHub
, python
, transmission
, deluge
, config
}:

with python.pkgs;

let

  sqlalchemy = callPackage (builtins.fetchurl "https://raw.githubusercontent.com/sjau/nix-expressions/master/sqlalchemy-1.1.10.nix") {};

in

buildPythonApplication rec {
  version = "2.13.0";
  name = "FlexGet-${version}";

  src = fetchFromGitHub {
    owner = "Flexget";
    repo = "Flexget";
    rev = version;
    sha256 = "014zfqr62q505sf3z7kfdqwyb1rfqw976b2fzcmddfh7q2i2nw3i";
  };

  doCheck = false;
  # test_regexp requires that HOME exist, test_filesystem requires a
  # unicode-capable filesystem (and setting LC_ALL doesn't work).
  # setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
  postPatch = ''
    substituteInPlace requirements.txt \
      --replace "chardet==3.0.3" "chardet" \
      --replace "rebulk==0.9.0" "rebulk" \
      --replace "cherrypy==10.2.2" "cherrypy" \
      --replace "portend==1.8" "portend" \
      --replace "sqlalchemy==1.1.10" "sqlalchemy" \
      --replace "zxcvbn-python==4.4.15" "zxcvbn-python" \
      --replace "flask-cors==3.0.2" "flask-cors" \
      --replace "certifi==2017.4.17" "certifi" \
      --replace "apscheduler==3.5.0" "apscheduler" \
      --replace "path.py==10.3.1" "path.py" \
      --replace "tempora==1.8" "tempora" \
      --replace "cheroot==5.5.0" "cheroot" \
      --replace "six==1.10.0" "six" \
      --replace "aniso8601==1.2.1" "aniso8601" \
      --replace "flask==0.12.2" "flask" \
      --replace "guessit==2.1.4" "guessit" \
      --replace "werkzeug==0.12.2" "werkzeug" \
      --replace "pytz==2017.2" "pytz" \
      --replace "tzlocal==1.4" "tzlocal" \
      --replace "html5lib==0.999999999" "html5lib" \
      --replace "jinja2==2.9.6" "jinja2" \
      --replace "urllib3==1.21.1" "urllib3" \
      --replace "plumbum==1.6.3" "plumbum" \
      --replace "idna==2.5" "idna" \
      --replace "requests==2.16.5" "requests"
  '';

  checkPhase = ''
    export HOME=.
    py.test --disable-pytest-warnings -k "not test_quality_failures \
                                          and not test_group_quality \
                                          and not crash_report \
                                          and not test_multi_episode \
                                          and not test_double_episodes \
                                          and not test_inject_force \
                                          and not test_double_prefered \
                                          and not test_double \
                                          and not test_non_ascii"
  '';

  buildInputs = [ pytest mock vcrpy pytest-catchlog boto3 ];
  propagatedBuildInputs = [
    feedparser sqlalchemy pyyaml chardet
    beautifulsoup4 html5lib PyRSS2Gen pynzb
    rpyc jinja2 jsonschema requests dateutil
    pathpy guessit_2_0 APScheduler
    terminaltables colorclass
    cherrypy flask flask-restful flask-restplus
    flask-compress flask_login flask-cors
    pyparsing safe future zxcvbn-python
    werkzeug tempora cheroot rebulk portend
    aniso8601 babelfish certifi click futures idna itsdangerous markupsafe plumbum pytz six tzlocal urllib3 webencodings werkzeug zxcvbn-python
  ] ++ lib.optional (pythonOlder "3.4") pathlib
    # enable deluge and transmission plugin support, if they're installed
    ++ lib.optional (config.deluge or false) deluge
    ++ lib.optional (transmission != null) transmissionrpc;

  meta = {
    homepage = https://flexget.com/;
    description = "Multipurpose automation tool for content like torrents";
    license = lib.licenses.mit;
    maintainers = with lib.maintainers; [ domenkozar tari ];
#    broken = true; # as of 2018-02-09
  };
}

@sjau
Copy link

sjau commented Mar 4, 2018

Upon further investigation, the problem with the 500 shows is becuase of SQLite limitations. By default it allows only 1000 max variables (and a problem with the current flexget code fills that with 500 shows).

Other distros do set significantly higher default value for max vars. Hence I made a PR: #36293

@rnhmjoj rnhmjoj force-pushed the flexget branch 3 times, most recently from af1a06f to 0649f52 Compare March 4, 2018 14:48
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 4, 2018

@sjau Thank you. I picked up your changes.

@sjau
Copy link

sjau commented Mar 4, 2018

I still don't know what the difference ist between pypi and directly getting the source though....

@yesbox
Copy link
Contributor

yesbox commented Mar 4, 2018

requirements.txt is generated from requirements.in which has fewer constraints and hopefully only direct dependencies. Would "mv requirements.in requirements.txt" before building be useful?

Flexget developers made this change due to dependency issues of their own: Flexget/Flexget#1867

@sjau
Copy link

sjau commented Mar 8, 2018

@rnhmjoj
I did now recompile sqlite with more variables to be used and the errors went away that I had before. I will also try your pypi flexget version probably on the weekend and see how it goes.

What is more desirable as nix expression?

  • directly from source; or
  • pypi?

@Ma27
Copy link
Member

Ma27 commented Mar 8, 2018

@sjau I think pypi is preferred, however you’ll need to fetch it directly from source if you’d like to get the tests running

@Mic92
Copy link
Member

Mic92 commented Mar 8, 2018

@GrahamcOfBorg eval
@GrahamcOfBorg build flexget

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

�[31;1merror:�[0m while evaluating anonymous function at �[1m/var/lib/gc-of-borg/nix-test-rs-8/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-8/pkgs/stdenv/generic/check-meta.nix�[0m:4:1, called from �[1m/var/lib/gc-of-borg/nix-test-rs-8/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-8/pkgs/stdenv/generic/make-derivation.nix�[0m:206:18:
while evaluating 'checkValidity' at �[1m/var/lib/gc-of-borg/nix-test-rs-8/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-8/pkgs/stdenv/generic/check-meta.nix�[0m:184:19, called from �[1m/var/lib/gc-of-borg/nix-test-rs-8/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-8/pkgs/stdenv/generic/check-meta.nix�[0m:199:15:
while evaluating 'hasDeniedUnfreeLicense' at �[1m/var/lib/gc-of-borg/nix-test-rs-8/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-8/pkgs/stdenv/generic/check-meta.nix�[0m:59:28, called from �[1m/var/lib/gc-of-borg/nix-test-rs-8/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-8/pkgs/stdenv/generic/check-meta.nix�[0m:185:8:
while evaluating 'isUnfree' at �[1m/var/lib/gc-of-borg/nix-test-rs-8/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-8/pkgs/stdenv/generic/check-meta.nix�[0m:44:14, called from �[1m/var/lib/gc-of-borg/nix-test-rs-8/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-8/pkgs/stdenv/generic/check-meta.nix�[0m:62:5:
while evaluating 'toList' at �[1m/var/lib/gc-of-borg/nix-test-rs-8/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-8/lib/lists.nix�[0m:221:12, called from �[1m/var/lib/gc-of-borg/nix-test-rs-8/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-8/pkgs/stdenv/generic/check-meta.nix�[0m:62:15:
while evaluating the attribute 'meta.license' at �[1m/var/lib/gc-of-borg/nix-test-rs-8/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-8/pkgs/applications/networking/flexget/default.nix�[0m:64:5:
undefined variable 'stdenv' at �[1m/var/lib/gc-of-borg/nix-test-rs-8/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-8/pkgs/applications/networking/flexget/default.nix�[0m:61:15

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

error: while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/stdenv/generic/check-meta.nix:4:1, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/stdenv/generic/make-derivation.nix:206:18:
while evaluating 'checkValidity' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/stdenv/generic/check-meta.nix:184:19, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/stdenv/generic/check-meta.nix:199:15:
while evaluating 'hasDeniedUnfreeLicense' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/stdenv/generic/check-meta.nix:59:28, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/stdenv/generic/check-meta.nix:185:8:
while evaluating 'isUnfree' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/stdenv/generic/check-meta.nix:44:14, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/stdenv/generic/check-meta.nix:62:5:
while evaluating 'toList' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/lists.nix:221:12, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/stdenv/generic/check-meta.nix:62:15:
while evaluating the attribute 'meta.license' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/networking/flexget/default.nix:64:5:
undefined variable 'stdenv' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/networking/flexget/default.nix:61:15

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 14, 2018

@GrahamcOfBorg build flexget

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: flexget

Partial log (click to expand)

/tmp/nix-build-FlexGet-2.13.0.drv-0/FlexGet-2.13.0
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/madmn023jfdhml8wrcbxs915224yi5wf-FlexGet-2.13.0
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/madmn023jfdhml8wrcbxs915224yi5wf-FlexGet-2.13.0/lib  /nix/store/madmn023jfdhml8wrcbxs915224yi5wf-FlexGet-2.13.0/bin 
patching script interpreter paths in /nix/store/madmn023jfdhml8wrcbxs915224yi5wf-FlexGet-2.13.0
checking for references to /tmp/nix-build-FlexGet-2.13.0.drv-0 in /nix/store/madmn023jfdhml8wrcbxs915224yi5wf-FlexGet-2.13.0...
wrapping `/nix/store/madmn023jfdhml8wrcbxs915224yi5wf-FlexGet-2.13.0/bin/flexget'...
wrapping `/nix/store/madmn023jfdhml8wrcbxs915224yi5wf-FlexGet-2.13.0/bin/flexget-headless'...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: flexget

Partial log (click to expand)

Installing collected packages: FlexGet
Successfully installed FlexGet-2.13.0
/private/tmp/nix-build-FlexGet-2.13.0.drv-0/FlexGet-2.13.0
glibPreFixupPhase
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/326ymbl0syl93vkjxgvfi2bw9ihvzswx-FlexGet-2.13.0/lib  /nix/store/326ymbl0syl93vkjxgvfi2bw9ihvzswx-FlexGet-2.13.0/bin
patching script interpreter paths in /nix/store/326ymbl0syl93vkjxgvfi2bw9ihvzswx-FlexGet-2.13.0
wrapping `/nix/store/326ymbl0syl93vkjxgvfi2bw9ihvzswx-FlexGet-2.13.0/bin/flexget'...
wrapping `/nix/store/326ymbl0syl93vkjxgvfi2bw9ihvzswx-FlexGet-2.13.0/bin/flexget-headless'...

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 14, 2018

Ok, sorry for the stupid error I didn't notice before.
@sjau Is there something else to change or it's good to merge?

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: flexget

Partial log (click to expand)

Installing collected packages: FlexGet
Successfully installed FlexGet-2.13.0
/private/tmp/nix-build-FlexGet-2.13.0.drv-0/FlexGet-2.13.0
glibPreFixupPhase
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/326ymbl0syl93vkjxgvfi2bw9ihvzswx-FlexGet-2.13.0/lib  /nix/store/326ymbl0syl93vkjxgvfi2bw9ihvzswx-FlexGet-2.13.0/bin
patching script interpreter paths in /nix/store/326ymbl0syl93vkjxgvfi2bw9ihvzswx-FlexGet-2.13.0
wrapping `/nix/store/326ymbl0syl93vkjxgvfi2bw9ihvzswx-FlexGet-2.13.0/bin/flexget-headless'...
wrapping `/nix/store/326ymbl0syl93vkjxgvfi2bw9ihvzswx-FlexGet-2.13.0/bin/flexget'...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: flexget

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zzzqkmk5wzlx2fawgmym369hdnqzvd8p-FlexGet-2.13.0
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/zzzqkmk5wzlx2fawgmym369hdnqzvd8p-FlexGet-2.13.0/lib  /nix/store/zzzqkmk5wzlx2fawgmym369hdnqzvd8p-FlexGet-2.13.0/bin
patching script interpreter paths in /nix/store/zzzqkmk5wzlx2fawgmym369hdnqzvd8p-FlexGet-2.13.0
checking for references to /build in /nix/store/zzzqkmk5wzlx2fawgmym369hdnqzvd8p-FlexGet-2.13.0...
wrapping `/nix/store/zzzqkmk5wzlx2fawgmym369hdnqzvd8p-FlexGet-2.13.0/bin/flexget-headless'...
wrapping `/nix/store/zzzqkmk5wzlx2fawgmym369hdnqzvd8p-FlexGet-2.13.0/bin/flexget'...
/nix/store/zzzqkmk5wzlx2fawgmym369hdnqzvd8p-FlexGet-2.13.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: flexget

Partial log (click to expand)

these derivations will be built:
  /nix/store/yak447dh1d2l7xabfrwa0qa5fb0gjw3s-python2.7-SQLAlchemy-1.2.3.drv
  /nix/store/nqdjjqpl3fxak414fnx6jhfhx3dnxl8x-FlexGet-2.13.0.drv
waiting for locks or build slots...
/nix/store/zzzqkmk5wzlx2fawgmym369hdnqzvd8p-FlexGet-2.13.0

@sjau
Copy link

sjau commented Mar 14, 2018

works good for me but I don't use a lot of plugins etc... so I'm happy with current state. However I noticed it's alread at 2.13.5. Maybe I should test that first.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: flexget

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/madmn023jfdhml8wrcbxs915224yi5wf-FlexGet-2.13.0
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/madmn023jfdhml8wrcbxs915224yi5wf-FlexGet-2.13.0/lib  /nix/store/madmn023jfdhml8wrcbxs915224yi5wf-FlexGet-2.13.0/bin
patching script interpreter paths in /nix/store/madmn023jfdhml8wrcbxs915224yi5wf-FlexGet-2.13.0
checking for references to /build in /nix/store/madmn023jfdhml8wrcbxs915224yi5wf-FlexGet-2.13.0...
wrapping `/nix/store/madmn023jfdhml8wrcbxs915224yi5wf-FlexGet-2.13.0/bin/flexget-headless'...
wrapping `/nix/store/madmn023jfdhml8wrcbxs915224yi5wf-FlexGet-2.13.0/bin/flexget'...
/nix/store/madmn023jfdhml8wrcbxs915224yi5wf-FlexGet-2.13.0

@sjau
Copy link

sjau commented Mar 14, 2018

v2.13.5 with hashsum 1lkmxwy7k4zlcqpigwk8skc2zi8a70vrw21pz80wvmf9yg0wc9z9 (Pypi) seems also to work just fine.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 14, 2018

Ok, done. @sjau Should I add you as a maintainer?

@sjau
Copy link

sjau commented Mar 14, 2018

no thx :)

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: flexget

Partial log (click to expand)

/tmp/nix-build-FlexGet-2.13.5.drv-0/FlexGet-2.13.5
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ngnxw17mwmfrysq496kk30nr2vb74wny-FlexGet-2.13.5
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ngnxw17mwmfrysq496kk30nr2vb74wny-FlexGet-2.13.5/lib  /nix/store/ngnxw17mwmfrysq496kk30nr2vb74wny-FlexGet-2.13.5/bin 
patching script interpreter paths in /nix/store/ngnxw17mwmfrysq496kk30nr2vb74wny-FlexGet-2.13.5
checking for references to /tmp/nix-build-FlexGet-2.13.5.drv-0 in /nix/store/ngnxw17mwmfrysq496kk30nr2vb74wny-FlexGet-2.13.5...
wrapping `/nix/store/ngnxw17mwmfrysq496kk30nr2vb74wny-FlexGet-2.13.5/bin/flexget'...
wrapping `/nix/store/ngnxw17mwmfrysq496kk30nr2vb74wny-FlexGet-2.13.5/bin/flexget-headless'...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: flexget

Partial log (click to expand)

Installing collected packages: FlexGet
Successfully installed FlexGet-2.13.5
/private/tmp/nix-build-FlexGet-2.13.5.drv-0/FlexGet-2.13.5
glibPreFixupPhase
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/qc7lpywpkhrlbd491ifwj5rxs117fw4n-FlexGet-2.13.5/lib  /nix/store/qc7lpywpkhrlbd491ifwj5rxs117fw4n-FlexGet-2.13.5/bin
patching script interpreter paths in /nix/store/qc7lpywpkhrlbd491ifwj5rxs117fw4n-FlexGet-2.13.5
wrapping `/nix/store/qc7lpywpkhrlbd491ifwj5rxs117fw4n-FlexGet-2.13.5/bin/flexget-headless'...
wrapping `/nix/store/qc7lpywpkhrlbd491ifwj5rxs117fw4n-FlexGet-2.13.5/bin/flexget'...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: flexget

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mcda3srfd3w10zylfd8amdqfb33r4qgs-FlexGet-2.13.5
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/mcda3srfd3w10zylfd8amdqfb33r4qgs-FlexGet-2.13.5/lib  /nix/store/mcda3srfd3w10zylfd8amdqfb33r4qgs-FlexGet-2.13.5/bin
patching script interpreter paths in /nix/store/mcda3srfd3w10zylfd8amdqfb33r4qgs-FlexGet-2.13.5
checking for references to /build in /nix/store/mcda3srfd3w10zylfd8amdqfb33r4qgs-FlexGet-2.13.5...
wrapping `/nix/store/mcda3srfd3w10zylfd8amdqfb33r4qgs-FlexGet-2.13.5/bin/flexget-headless'...
wrapping `/nix/store/mcda3srfd3w10zylfd8amdqfb33r4qgs-FlexGet-2.13.5/bin/flexget'...
/nix/store/mcda3srfd3w10zylfd8amdqfb33r4qgs-FlexGet-2.13.5

maintainers = with lib.maintainers; [ domenkozar tari ];
broken = true; # as of 2018-02-09
license = licenses.mit;
maintainers = with maintainers; [ ];
Copy link
Member

@Mic92 Mic92 Mar 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@domenkozar @tari are you ok with this? I tried to align the maintainers field with reality.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, fine with me.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: flexget

Partial log (click to expand)

/nix/store/ngnxw17mwmfrysq496kk30nr2vb74wny-FlexGet-2.13.5

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: flexget

Partial log (click to expand)

Installing collected packages: FlexGet
Successfully installed FlexGet-2.13.5
/private/tmp/nix-build-FlexGet-2.13.5.drv-0/FlexGet-2.13.5
glibPreFixupPhase
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/qc7lpywpkhrlbd491ifwj5rxs117fw4n-FlexGet-2.13.5/lib  /nix/store/qc7lpywpkhrlbd491ifwj5rxs117fw4n-FlexGet-2.13.5/bin
patching script interpreter paths in /nix/store/qc7lpywpkhrlbd491ifwj5rxs117fw4n-FlexGet-2.13.5
wrapping `/nix/store/qc7lpywpkhrlbd491ifwj5rxs117fw4n-FlexGet-2.13.5/bin/flexget'...
wrapping `/nix/store/qc7lpywpkhrlbd491ifwj5rxs117fw4n-FlexGet-2.13.5/bin/flexget-headless'...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: flexget

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mcda3srfd3w10zylfd8amdqfb33r4qgs-FlexGet-2.13.5
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/mcda3srfd3w10zylfd8amdqfb33r4qgs-FlexGet-2.13.5/lib  /nix/store/mcda3srfd3w10zylfd8amdqfb33r4qgs-FlexGet-2.13.5/bin
patching script interpreter paths in /nix/store/mcda3srfd3w10zylfd8amdqfb33r4qgs-FlexGet-2.13.5
checking for references to /build in /nix/store/mcda3srfd3w10zylfd8amdqfb33r4qgs-FlexGet-2.13.5...
wrapping `/nix/store/mcda3srfd3w10zylfd8amdqfb33r4qgs-FlexGet-2.13.5/bin/flexget-headless'...
wrapping `/nix/store/mcda3srfd3w10zylfd8amdqfb33r4qgs-FlexGet-2.13.5/bin/flexget'...
/nix/store/mcda3srfd3w10zylfd8amdqfb33r4qgs-FlexGet-2.13.5

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 17, 2018

So, can we merge it now?

@Mic92 Mic92 merged commit c32e94c into NixOS:master Mar 17, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 17, 2018

I backported it also the sqlite change is still not applied to 18.03, see 473fd8a and 3c3e44a

@rnhmjoj rnhmjoj deleted the flexget branch February 23, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants