dhall: passthru dhall prelude #35558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
|
|
||
| in static.overrideAttrs (old: { | ||
| passthru = old.passthru or {} // { | ||
| prelude = stdenv.mkDerivation { |
There was a problem hiding this comment.
I think you can use runCommand instead of stdenv.mkDerivation. Besides simplifying the expression it also involves an unnecessary build-time dependence on the C compiler:
prelude = runCommand "dhall-prelude" {} ''
mkdir $out
cp -r ${old.src}/Prelude/* $out/
''There was a problem hiding this comment.
That doesn’t work (tried it) because old.src is a .tar.gz. What could work is invoking stdenv manually, but I don’t know if it’s worth the effort.
There was a problem hiding this comment.
In that case you can use stdenvNoCC instead of stdenv, which at least removes the build-time dependency on the C compiler
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Profpatsch
force-pushed
the
dhall-passthru-prelude
branch
from
d2e1d21
to
e06789b
Compare
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
@GrahamcOfBorg build dhall.prelude |
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Makes it possible to reference `dhall.prelude`, the same version that comes with the dhall exetutable’s source code.
Profpatsch
force-pushed
the
dhall-passthru-prelude
branch
from
e06789b
to
4b70328
Compare
|
Corrected the invocation in |
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to reference
dhall.prelude, the same version that comes withthe dhall exetutable’s source code.
cc @Gabriel439 @ocharles