Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spidermonkey_52: 52.2.1gnome1 → 52.6.0 #35592

Merged
merged 1 commit into from Feb 28, 2018
Merged

spidermonkey_52: 52.2.1gnome1 → 52.6.0 #35592

merged 1 commit into from Feb 28, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Feb 25, 2018 •
edited

Motivation for this change

Update to latest upstream version and remove some flags that caused errors:

--enable-threadsafe was removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1253466, since SpiderMonkey is thread-safe by default now https://bugzilla.mozilla.org/show_bug.cgi?id=1031529.

--enable-gcgenerational also disappeared for some reason.

They had to be removed at some point between 52.2.1 and 52.4.0, which I also tested.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test
    • gjs
  • Tested compilation of all pkgs that depend on this change
    • gnome3.gjs
  • Tested execution of all binary files (usually in ./result/bin/)
    • js52
    • js52-config
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘spidermonkey-52.6.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/interpreters/spidermonkey/52.nix:47 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vmk2hgm687yx24jwacbr843r32gg5sic-spidermonkey-52.6.0
shrinking /nix/store/vmk2hgm687yx24jwacbr843r32gg5sic-spidermonkey-52.6.0/bin/js52
shrinking /nix/store/vmk2hgm687yx24jwacbr843r32gg5sic-spidermonkey-52.6.0/lib/libmozjs-52.so
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/vmk2hgm687yx24jwacbr843r32gg5sic-spidermonkey-52.6.0/lib  /nix/store/vmk2hgm687yx24jwacbr843r32gg5sic-spidermonkey-52.6.0/bin 
patching script interpreter paths in /nix/store/vmk2hgm687yx24jwacbr843r32gg5sic-spidermonkey-52.6.0
/nix/store/vmk2hgm687yx24jwacbr843r32gg5sic-spidermonkey-52.6.0/bin/js52-config: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-spidermonkey-52.6.0.drv-0 in /nix/store/vmk2hgm687yx24jwacbr843r32gg5sic-spidermonkey-52.6.0...
/nix/store/vmk2hgm687yx24jwacbr843r32gg5sic-spidermonkey-52.6.0

@jtojnar
Copy link
Contributor Author

jtojnar commented Feb 28, 2018

@GrahamcOfBorg test gjs

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 528.55s
cleaning up
killing machine (pid 596)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-gjs.drv-0/vde1.ctl': Directory not empty
/nix/store/r5syypjzr4wml7561x4yr8miffaarxp7-vm-test-run-gjs

@jtojnar
spidermonkey_52: 52.2.1gnome1 → 52.6.0
0a99152 
Update to latest upstream version and remove some flags that caused errors:

--enable-threadsafe was removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1253466, since SpiderMonkey is thread-safe by default now https://bugzilla.mozilla.org/show_bug.cgi?id=1031529.

--enable-gcgenerational also disappeared for some reason.
@jtojnar jtojnar merged commit 0a99152 into NixOS:master Feb 28, 2018
@jtojnar jtojnar deleted the spidermonkey branch February 28, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @GrahamcOfBorg