jmeter: 3.3 -> 4.0 #35655
jmeter: 3.3 -> 4.0 #35655
Conversation
|
I think you're right @volth, I am currently investigating it seems like there is nothing to substitute anyway because the script does already in 3.3 no longer have this line. |
|
@volth Okay I refactored the package a bit, could you make another review pass? Things done:
|
| buildInputs = [ jre ]; | ||
| buildInputs = [ jre makeWrapper ]; | ||
|
|
||
| phases = [ "unpackPhase" "installPhase" "checkPhase" "fixupPhase" ]; |
There was a problem hiding this comment.
Please use dontBuild = true instead.
There was a problem hiding this comment.
I also had to change the order of the checkPhase though. That means I have to keep it, no?
| }; | ||
|
|
||
| buildInputs = [ jre ]; | ||
| buildInputs = [ jre makeWrapper ]; |
There was a problem hiding this comment.
makeWrapper should be in nativeBuildInputs.
|
@volhovm Do you refer to the I can add that, but I still need that line because I am reordering the |
markus1189
force-pushed
the
jmeter
branch
3 times, most recently
from
8a500cd
to
acfabea
Compare
|
@volth Already included in the latest commit. Thanks for the pr that is much nicer |
|
there is a bit more wrapping needed: $ /nix/store/34wdgmwq6gqhzbyzx18sig78jh4yrygz-jmeter-4.0/bin/jmeter-create-rmi-keystore.sh: line 18: keytool: command not found
Copy the generated rmi_keystore.jks to jmeter/bin folder or reference it in property 'server.rmi.ssl.keystore.file'
$ /nix/store/34wdgmwq6gqhzbyzx18sig78jh4yrygz-jmeter-4.0/bin/jmeter-heapdump.sh: line 24: java: command not found
$ /nix/store/34wdgmwq6gqhzbyzx18sig78jh4yrygz-jmeter-4.0/bin/jmeter-mirror-server.sh: line 27: java: command not found
$ /nix/store/34wdgmwq6gqhzbyzx18sig78jh4yrygz-jmeter-4.0/bin/jmeter-mirror-server.sh: line 27: java: command not found |
|
Done ;) I really like how this came out, it's a good improvement of the old package, thanks for all the feedback! |
|
the following are still missing java: $ /nix/store/6867z1rhini3q3qwps2d8brd2k49r2xs-jmeter-4.0/bin/jmeter-shutdown.sh: line 24: java: command not found
$ /nix/store/6867z1rhini3q3qwps2d8brd2k49r2xs-jmeter-4.0/bin/jmeter-stoptest.sh: line 24: java: command not found |
|
Updated and added more tests. Is the use of |
|
The test still has $ jmeter-shutdown.sh
/nix/store/rz9lbp3i22mj8dcqcpwz4lhlcld3aqpr-jmeter-4.0/bin/.jmeter-shutdown.sh-wrapped: line 24: java: command not found |
markus1189
force-pushed
the
jmeter
branch
2 times, most recently
from
3ab5e9b
to
3cb940a
Compare
|
Should be fixed now |
[x] Tested execution of binary file