Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lutris: init at 0.4.14 #35609

Closed
wants to merge 1 commit into from
Closed

lutris: init at 0.4.14 #35609

wants to merge 1 commit into from

Conversation

othercriteria
Copy link

Works well enough to launch Lutris GUI, and sync with Steam library,
although I can't get it to run external programs due to weird bash
issues.

Motivation for this change

No existing package existed for it and I wanted to try it out.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@othercriteria
lutris: init at 0.4.14
231bff0 
Works well enough to launch Lutris GUI, and sync with Steam library,
although I can't get it to run external programs due to weird bash
issues.
lukateras
lukateras requested changes Mar 7, 2018
View reviewed changes
Copy link
Member

@lukateras lukateras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't take care of Lutris components installable via the interface (IIRC that includes Wine, various emulators). The proper solution is buildFHSUserEnv.

@othercriteria
Copy link
Author

othercriteria commented Mar 7, 2018 via email

@soredake
Copy link

Any progress?

@othercriteria
Copy link
Author

Reading up on buildFHSUserEnv, but don't have a solid idea yet of how to use it together with buildPythonApplication.

Will hopefully have a chance to play with this this weekend.

@soredake
Copy link

Hope you finish the pr someday

@tenten8401
Copy link

You should possibly init/update this to 0.4.16 as some updates have passed recently.

@soredake
Copy link

soredake commented Jun 7, 2018 •
edited

@yegortimoshenko can you please finish this package? It is the only thing that stoping me from migration to nixos

@lukateras
Copy link
Member

@soredake If that much is at stake, OK :-)

@lukateras lukateras self-assigned this Jun 7, 2018
@tenten8401
Copy link

tenten8401 commented Jun 7, 2018 •
edited

I'm currently on NixOS too and the one thing I'm missing is Lutris. It'd be absolutely sick to see this get done.

Since my last comment though, Lutris has released 0.4.18 too, which includes a bunch of goodies such a DXVK support for Wine built in and quite a bit of bugfixes. It'd be nice to see this get bumped to that version before it's merged.

@Chiiruno
Copy link
Contributor

See: #42075

@lukateras lukateras closed this Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras requested changes

Assignees

@lukateras lukateras

Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@othercriteria @soredake @tenten8401 @lukateras @Chiiruno @GrahamcOfBorg @Janik-Haag