Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cacert: add output "unbundled" for individual certificates #35588

Merged
merged 1 commit into from Mar 11, 2018
Merged

cacert: add output "unbundled" for individual certificates #35588

merged 1 commit into from Mar 11, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Feb 25, 2018 •
edited

Motivation for this change

For some applications it is convenient to have access to individual root certificates instead of a bundle.
This change adds a new output "unbundled" containing each cert in a separate file.
It is not installed by default.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc maintainers: @wkennington @fpletz

@xeji
cacert: add output "unbundled"
c9a1639 
which contains all certs, each in a separate file.
This output is not installed by default.
@xeji xeji changed the base branch from master to staging February 25, 2018 22:49
@xeji
Copy link
Contributor Author

xeji commented Mar 10, 2018

@GrahamcOfBorg build cacert

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/714k9dsgmz73rxzjpvw3lmn815frkby6-nss-cacert-3.34.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/714k9dsgmz73rxzjpvw3lmn815frkby6-nss-cacert-3.34.1
strip is /nix/store/fib7s4bkwwh54jz3b9yhb3sqmlcdks0n-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/714k9dsgmz73rxzjpvw3lmn815frkby6-nss-cacert-3.34.1
checking for references to /build in /nix/store/714k9dsgmz73rxzjpvw3lmn815frkby6-nss-cacert-3.34.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/c3m25m7263pnr3gbqxrnbva4xcf56n0f-nss-cacert-3.34.1-unbundled
strip is /nix/store/fib7s4bkwwh54jz3b9yhb3sqmlcdks0n-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/c3m25m7263pnr3gbqxrnbva4xcf56n0f-nss-cacert-3.34.1-unbundled
checking for references to /build in /nix/store/c3m25m7263pnr3gbqxrnbva4xcf56n0f-nss-cacert-3.34.1-unbundled...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cacert

Partial log (click to expand)

'thawte_Primary_Root_CA_-_G3.crt' -> '/nix/store/bxggpgnih28jrhi5v610rmkdqq82lz1b-nss-cacert-3.34.1-unbundled/etc/ssl/certs/thawte_Primary_Root_CA_-_G3.crt'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/32xjwa8nf84sipbz8f92x7qxrykjvcf5-nss-cacert-3.34.1
strip is /nix/store/y2z2g4n8dsv0isjq36cjn9ldp8h9z3gs-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/32xjwa8nf84sipbz8f92x7qxrykjvcf5-nss-cacert-3.34.1
checking for references to /tmp/nix-build-nss-cacert-3.34.1.drv-0 in /nix/store/32xjwa8nf84sipbz8f92x7qxrykjvcf5-nss-cacert-3.34.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/bxggpgnih28jrhi5v610rmkdqq82lz1b-nss-cacert-3.34.1-unbundled
strip is /nix/store/y2z2g4n8dsv0isjq36cjn9ldp8h9z3gs-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/bxggpgnih28jrhi5v610rmkdqq82lz1b-nss-cacert-3.34.1-unbundled
checking for references to /tmp/nix-build-nss-cacert-3.34.1.drv-0 in /nix/store/bxggpgnih28jrhi5v610rmkdqq82lz1b-nss-cacert-3.34.1-unbundled...

@7c6f434c 7c6f434c merged commit bf41b46 into NixOS:staging Mar 11, 2018
@xeji xeji deleted the cacert-unbundled branch March 11, 2018 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @7c6f434c