Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Socket Constants #5746

Closed
wants to merge 3 commits into from
Closed

Additional Socket Constants #5746

wants to merge 3 commits into from

Conversation

bararchy
Copy link
Contributor

No description provided.

@bararchy bararchy mentioned this pull request Feb 25, 2018
Closed
@bararchy bararchy changed the title BLUETOOTH Constants for Socket Additional Socket Constants Feb 26, 2018
ysbaddaden
ysbaddaden reviewed Feb 26, 2018
View reviewed changes
Copy link
Contributor

@ysbaddaden ysbaddaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • These constants aren't defined in netinet/in.h or sys/socket.h but in bluetooth/bluetooth.h.
  • They're usually not available until we install a package.
  • There are a bunch more protocols than RFCOMM.

@bararchy
Copy link
Contributor Author

@ysbaddaden This is true, but I don't see any other way to add those in.
And, those places are the logical files to add the constants in.

If you can think about a better way I can do it I would love feedback.

@bararchy bararchy closed this Feb 26, 2018
@ysbaddaden
Copy link
Contributor

I suppose that would do the trick (I always forget we can forge enum values):
#5748 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysbaddaden ysbaddaden ysbaddaden left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bararchy @ysbaddaden