Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RDY] protocol: module to application #34868

Merged
merged 1 commit into from Mar 3, 2018
Merged

[RDY] protocol: module to application #34868

merged 1 commit into from Mar 3, 2018

Conversation

teto
Copy link
Member

@teto teto commented Feb 12, 2018

protocol really is a "buildPythonApplication" rather than a
buildPythonPackage".

Motivation for this change

I want to install it globally without having python globally available.

Things done

@teto teto requested a review from FRidh as a code owner February 12, 2018 03:23
FRidh
FRidh requested changes Feb 14, 2018
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's an application it should be moved out of python-packages.nix and python-modules.

@teto
Copy link
Member Author

teto commented Feb 18, 2018

arf had forgotten about that. It should be fixed now.

@teto
protocol: module to application
88dae1a 
protocol really is a "buildPythonApplication" rather than a
buildPythonPackage".
@teto teto changed the title protocol: module to application [RDY] protocol: module to application Feb 21, 2018
@Mic92 Mic92 merged commit ce6adf6 into NixOS:master Mar 3, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 3, 2018

Thanks!

@teto teto deleted the protocol branch March 3, 2018 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teto @Mic92 @FRidh @GrahamcOfBorg