Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: 6.12.2 -> 6.12.3 (maintenance) #34860

Merged
merged 1 commit into from Feb 12, 2018
Merged

nodejs: 6.12.2 -> 6.12.3 (maintenance) #34860

merged 1 commit into from Feb 12, 2018

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Feb 11, 2018

https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V6.md#6.12.3

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member Author

vcunat commented Feb 11, 2018

I found this as a by-product; I never used nodejs (contrary to libuv). /cc maintainers: @cillianderoiste, @Havvy, @gilligan, @cko.

@gilligan
Copy link
Contributor

LGTM!

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/w84lrd72wasdnvyv4cxgax0zk2a4zhl0-nodejs-6.12.3/lib/node_modules/npm/scripts/index-build.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/w84lrd72wasdnvyv4cxgax0zk2a4zhl0-nodejs-6.12.3/bin/node"
/nix/store/w84lrd72wasdnvyv4cxgax0zk2a4zhl0-nodejs-6.12.3/lib/node_modules/npm/scripts/maketest: interpreter directive changed from "/usr/bin/env node" to "/nix/store/w84lrd72wasdnvyv4cxgax0zk2a4zhl0-nodejs-6.12.3/bin/node"
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/w84lrd72wasdnvyv4cxgax0zk2a4zhl0-nodejs-6.12.3
shrinking /nix/store/w84lrd72wasdnvyv4cxgax0zk2a4zhl0-nodejs-6.12.3/bin/node
gzipping man pages under /nix/store/w84lrd72wasdnvyv4cxgax0zk2a4zhl0-nodejs-6.12.3/share/man/
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/w84lrd72wasdnvyv4cxgax0zk2a4zhl0-nodejs-6.12.3/lib  /nix/store/w84lrd72wasdnvyv4cxgax0zk2a4zhl0-nodejs-6.12.3/bin
patching script interpreter paths in /nix/store/w84lrd72wasdnvyv4cxgax0zk2a4zhl0-nodejs-6.12.3
checking for references to /build in /nix/store/w84lrd72wasdnvyv4cxgax0zk2a4zhl0-nodejs-6.12.3...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/4x39fr8vww41wzpqnp0zq5rvca6z7pjp-nodejs-6.12.3/lib/node_modules/npm/cli.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/4x39fr8vww41wzpqnp0zq5rvca6z7pjp-nodejs-6.12.3/bin/node"
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4x39fr8vww41wzpqnp0zq5rvca6z7pjp-nodejs-6.12.3
shrinking /nix/store/4x39fr8vww41wzpqnp0zq5rvca6z7pjp-nodejs-6.12.3/bin/node
gzipping man pages under /nix/store/4x39fr8vww41wzpqnp0zq5rvca6z7pjp-nodejs-6.12.3/share/man/
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4x39fr8vww41wzpqnp0zq5rvca6z7pjp-nodejs-6.12.3/lib  /nix/store/4x39fr8vww41wzpqnp0zq5rvca6z7pjp-nodejs-6.12.3/bin
patching script interpreter paths in /nix/store/4x39fr8vww41wzpqnp0zq5rvca6z7pjp-nodejs-6.12.3
checking for references to /build in /nix/store/4x39fr8vww41wzpqnp0zq5rvca6z7pjp-nodejs-6.12.3...
/nix/store/4x39fr8vww41wzpqnp0zq5rvca6z7pjp-nodejs-6.12.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/iy53yi46wgxhn6s5wi0n22bac7d9ncsv-nodejs-6.12.3/lib/node_modules/npm/node_modules/nopt/examples/my-program.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/iy53yi46wgxhn6s5wi0n22bac7d9ncsv-nodejs-6.12.3/bin/node"
/nix/store/iy53yi46wgxhn6s5wi0n22bac7d9ncsv-nodejs-6.12.3/lib/node_modules/npm/scripts/index-build.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/iy53yi46wgxhn6s5wi0n22bac7d9ncsv-nodejs-6.12.3/bin/node"
/nix/store/iy53yi46wgxhn6s5wi0n22bac7d9ncsv-nodejs-6.12.3/lib/node_modules/npm/scripts/maketest: interpreter directive changed from "/usr/bin/env node" to "/nix/store/iy53yi46wgxhn6s5wi0n22bac7d9ncsv-nodejs-6.12.3/bin/node"
/nix/store/iy53yi46wgxhn6s5wi0n22bac7d9ncsv-nodejs-6.12.3/lib/node_modules/npm/cli.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/iy53yi46wgxhn6s5wi0n22bac7d9ncsv-nodejs-6.12.3/bin/node"
post-installation fixup
gzipping man pages under /nix/store/iy53yi46wgxhn6s5wi0n22bac7d9ncsv-nodejs-6.12.3/share/man/
strip is /nix/store/5a88zk3jgimdmzg8rfhvm93kxib3njf9-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/iy53yi46wgxhn6s5wi0n22bac7d9ncsv-nodejs-6.12.3/lib  /nix/store/iy53yi46wgxhn6s5wi0n22bac7d9ncsv-nodejs-6.12.3/bin
patching script interpreter paths in /nix/store/iy53yi46wgxhn6s5wi0n22bac7d9ncsv-nodejs-6.12.3
/nix/store/iy53yi46wgxhn6s5wi0n22bac7d9ncsv-nodejs-6.12.3

@adisbladis adisbladis merged commit d66174e into NixOS:master Feb 12, 2018
@adisbladis
Copy link
Member

Backported to 17.09 in 395fe7f

@vcunat vcunat deleted the p/nodejs-6_x branch February 12, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9.needs: community feedback 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vcunat @gilligan @GrahamcOfBorg @adisbladis