morty: init -> 0.2.0 #34886
Merged
morty: init -> 0.2.0 #34886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
reviewed
Feb 12, 2018
nixos/tests/morty.nix
Outdated
| enable = true; | ||
| key = "78a9cd0cfee20c672f78427efb2a2a96036027f0"; | ||
| port = 3001; | ||
| }; |
There was a problem hiding this comment.
Please unindent enable by 2 spaces, then indent the rest to be in line with the enable line.
grahamc
reviewed
Feb 12, 2018
| * No Caching/Etag | ||
| * Supports GET/POST forms and IFrames | ||
| * Optional HMAC URL verifier key to prevent service abuse | ||
| "; |
There was a problem hiding this comment.
Please use '' instead of " (use two single quotes instead of one double-quote) on long text blocks. Also, move the first line of the text to its own line. Finally, the maintainer line should be maintainers.
joachifm
reviewed
Feb 16, 2018
nixos/modules/misc/ids.nix
Outdated
| @@ -576,6 +577,7 @@ | |||
| mighttpd2 = 285; | |||
| hass = 286; | |||
| monero = 287; | |||
| morty = 288; | |||
There was a problem hiding this comment.
Why does this need a static uid?
There was a problem hiding this comment.
I'm new at packaging services, and basically replicated the setup of searx which is its companion tool. That set uid and gid, so I did that for morty as well.
Is there a checklist for adding services somewhere?
There was a problem hiding this comment.
Not really; I'm just wondering whether there's a reason for allocating a uid; if there's a reason that's totally fine, otherwise you can probably get away with dynamic uids.
There was a problem hiding this comment.
I'm certainly not an expert in this. If you want this removed, let me know.
There was a problem hiding this comment.
What type of data does the service generate? Are you likely to transfer it across hosts & is it too expensive to fixup permissions at service start or do you need to refer to the uid before the uid/name mapping is established? If so, using a static uid may be appropriate. I'm happy to defer to your judgement regarding the service, I know nothing about it, but often static uids are used for no good reason and so the pattern propagates.
|
I removed the fixed uid/gid mapping, under the assumption that a proxy has little worthwhile state. |
|
@GrahamcOfBorg test morty |
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
|
@GrahamcOfBorg test morty |
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: tests.morty Partial log (click to expand)
|
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: tests.morty Partial log (click to expand)
|
joachifm
reviewed
May 27, 2018
| config = mkIf config.services.morty.enable { | ||
|
|
||
| users.extraUsers.morty = | ||
| { uid = config.ids.uids.morty; |
There was a problem hiding this comment.
Eval error here & below. Just leave unspecified to have ids dynamically allocated.
There was a problem hiding this comment.
Fixed this, and also updated to fresh release.
|
@GrahamcOfBorg test morty |
|
Success on x86_64-linux (full log) Attempted: tests.morty Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: tests.morty Partial log (click to expand)
|
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/php/versions. These checks were done: - built on NixOS - /nix/store/25l2hz7njpg9glpmslcadkgqwai5f77s-php-7.2.6/bin/phar.phar passed the binary check. - /nix/store/25l2hz7njpg9glpmslcadkgqwai5f77s-php-7.2.6/bin/phar passed the binary check. - /nix/store/25l2hz7njpg9glpmslcadkgqwai5f77s-php-7.2.6/bin/php passed the binary check. - /nix/store/25l2hz7njpg9glpmslcadkgqwai5f77s-php-7.2.6/bin/phpdbg passed the binary check. - /nix/store/25l2hz7njpg9glpmslcadkgqwai5f77s-php-7.2.6/bin/php-cgi passed the binary check. - /nix/store/25l2hz7njpg9glpmslcadkgqwai5f77s-php-7.2.6/bin/pear passed the binary check. - /nix/store/25l2hz7njpg9glpmslcadkgqwai5f77s-php-7.2.6/bin/peardev passed the binary check. - /nix/store/25l2hz7njpg9glpmslcadkgqwai5f77s-php-7.2.6/bin/pecl passed the binary check. - /nix/store/25l2hz7njpg9glpmslcadkgqwai5f77s-php-7.2.6/bin/php-fpm passed the binary check. - 9 of 9 passed binary check by having a zero exit code. - 0 of 9 passed binary check by having the new version present in output. - found 7.2.6 with grep in /nix/store/25l2hz7njpg9glpmslcadkgqwai5f77s-php-7.2.6 - directory tree listing: https://gist.github.com/409d2cfaa7e805714825281fbaba0d0f - du listing: https://gist.github.com/7fbd8e3d56524f70b3dfb94c045fccd2
|
LGTM, though to be strictly conforming to the guidelines this should ideally be one commit for the package and one for the service, with appropriate commit subjects. |
|
@joachifm: split into one commit for the package and one for the service. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This tool complements searx (from the same author), and provides a proxy service that can be used for visiting search results from the search engine.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)