Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trivial: nixos: doc: efficient comparisons #34866

Merged
merged 3 commits into from Feb 12, 2018

Conversation

oxij
Copy link
Member

@oxij oxij commented Feb 12, 2018

Motivation for this change

Me eating up all of the precious hydra memory and much of its time with a7d75ab of #33898. See that PR for discussion.

Things done

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff seems to be without down-sides. I agree with

Lets merge this and then see if you still want an option to disable sorting.

@vcunat
Copy link
Member

vcunat commented Feb 12, 2018

Ah, splitString – reminds me the line from the documentation :-)

NOTE: this function is not performant and should never be used.

@vcunat vcunat merged commit b468f98 into NixOS:master Feb 12, 2018
vcunat added a commit that referenced this pull request Feb 12, 2018
This solves most of the performance regression from a7d75ab (#33898).
@oxij oxij deleted the os/doc/efficient-comparisons branch September 8, 2018 22:16
c00w added a commit to c00w/nixpkgs that referenced this pull request Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants