Skip to content

Commit

Permalink
nodejs*: use older openssl
Browse files Browse the repository at this point in the history
nodejs v9 seems the only one supporting 1.1.0.
This kind of package seems relatively safe to use
another version of a library.
  • Loading branch information
vcunat committed Feb 11, 2018
1 parent 5bc89ca commit 63c5c8a
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 11 deletions.
2 changes: 1 addition & 1 deletion pkgs/development/node-packages/default-v6.nix
Expand Up @@ -13,7 +13,7 @@ nodePackages // {
dnschain = nodePackages.dnschain.override (oldAttrs: {
buildInputs = oldAttrs.buildInputs ++ [ pkgs.makeWrapper nodePackages.coffee-script ];
postInstall = ''
wrapProgram $out/bin/dnschain --suffix PATH : ${pkgs.openssl.bin}/bin
wrapProgram $out/bin/dnschain --suffix PATH : ${nodejs.openssl.bin}/bin
'';
});

Expand Down
2 changes: 1 addition & 1 deletion pkgs/development/node-packages/default-v8.nix
Expand Up @@ -13,7 +13,7 @@ nodePackages // {
dnschain = nodePackages.dnschain.override (oldAttrs: {
buildInputs = oldAttrs.buildInputs ++ [ pkgs.makeWrapper nodePackages.coffee-script ];
postInstall = ''
wrapProgram $out/bin/dnschain --suffix PATH : ${pkgs.openssl.bin}/bin
wrapProgram $out/bin/dnschain --suffix PATH : ${nodejs.openssl.bin}/bin
'';
});

Expand Down
8 changes: 5 additions & 3 deletions pkgs/development/web/nodejs/nodejs.nix
Expand Up @@ -50,8 +50,6 @@ in

enableParallelBuilding = true;

passthru.interpreterName = "nodejs";

setupHook = ./setup-hook.sh;

inherit patches;
Expand Down Expand Up @@ -84,5 +82,9 @@ in
platforms = platforms.linux ++ platforms.darwin;
};

passthru.python = python2; # to ensure nodeEnv uses the same version
passthru = {
interpreterName = "nodejs";
python = python2; # to ensure nodeEnv uses the same version
inherit openssl;
};
}
4 changes: 2 additions & 2 deletions pkgs/development/web/nodejs/v4.nix
@@ -1,7 +1,7 @@
{ stdenv, callPackage, lib, enableNpm ? true }:
{ stdenv, callPackage, lib, enableNpm ? true, openssl_1_0_2 }:

let
buildNodejs = callPackage ./nodejs.nix {};
buildNodejs = callPackage ./nodejs.nix { openssl = openssl_1_0_2; };
in
buildNodejs {
inherit enableNpm;
Expand Down
4 changes: 2 additions & 2 deletions pkgs/development/web/nodejs/v6.nix
@@ -1,7 +1,7 @@
{ stdenv, callPackage, lib, enableNpm ? true }:
{ stdenv, callPackage, lib, enableNpm ? true, openssl_1_0_2 }:

let
buildNodejs = callPackage ./nodejs.nix {};
buildNodejs = callPackage ./nodejs.nix { openssl = openssl_1_0_2; };
in
buildNodejs {
inherit enableNpm;
Expand Down
4 changes: 2 additions & 2 deletions pkgs/development/web/nodejs/v8.nix
@@ -1,7 +1,7 @@
{ stdenv, callPackage, lib, enableNpm ? true }:
{ stdenv, callPackage, lib, enableNpm ? true, openssl_1_0_2 }:

let
buildNodejs = callPackage ./nodejs.nix {};
buildNodejs = callPackage ./nodejs.nix { openssl = openssl_1_0_2; };
in
buildNodejs {
inherit enableNpm;
Expand Down

0 comments on commit 63c5c8a

Please sign in to comment.