pythonPackages.aioconsole: init at 0.1.7 #34853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
Feb 11, 2018
| buildPythonPackage rec { | ||
| pname = "aioconsole"; | ||
| version = "0.1.7"; | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
The name attribute is added by buildPython* and should therefore be removed.
| name = "${pname}-${version}"; | ||
|
|
||
| # tests are not included in the version on PyPI | ||
| src = fetchzip { |
| sha256 = "0p12viyngplqds7xkwysfh1nlgrny8hwja2mm2na0wzfxj04fbcd"; | ||
| }; | ||
|
|
||
| buildInputs = [ pytest pytest-asyncio pytestcov ]; |
There was a problem hiding this comment.
checkInputs
Also, you were building without sandbox and missed pytestrunner.
| }; | ||
|
|
||
| buildInputs = [ pytest pytest-asyncio pytestcov ]; | ||
|
|
There was a problem hiding this comment.
doCheck = false; is needed because our pytest-asyncio is too new
| meta = with stdenv.lib; { | ||
| homepage = https://github.com/vxgmichel/aioconsole; | ||
| license = licenses.gpl3; | ||
| description = "Asynchronous console and interfaces for asyncio"; |
There was a problem hiding this comment.
will you maintain this expression?
|
@GrahamcOfBorg build pythonPackages.aioconsole python3Packages.aioconsole |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
@GrahamcOfBorg build python3Packages.aioconsole |
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adding aioconsole. Note the comment in the expression about the caveat for the "apython" binary this derivation provides.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)