Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontconfig: Fix for HFS+ 1s date resolution issue #34878

Merged
merged 1 commit into from Feb 24, 2018

Conversation

hamishmack
Copy link
Contributor

HFS+ (still common on macOS machines) only has a
date resolution of 1 second. This change makes sure that
fcobjshash.h gets a newer timestamp than fcobjshash.gperf.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

HFS+ (still common on macOS machines) only has a
date resolution of 1 second.  This change makes sure that
`fcobjshash.h` gets a newer timestamp than `fcobjshash.gperf`.
@veprbl
Copy link
Member

veprbl commented Feb 12, 2018

Oh yes! I had this problem on GPFS too.

@vcunat vcunat changed the base branch from master to staging February 24, 2018 12:20
@vcunat vcunat merged commit 6ad7452 into NixOS:staging Feb 24, 2018
vcunat added a commit that referenced this pull request Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants