Fixing component migration #3164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sithhell
commented
Feb 11, 2018
sithhell
commented
- Simplified migration handling in primary namespace
- Fixing various race conditions
hkaiser
reviewed
Feb 11, 2018
| hpx::future<bool> end_migration_async(naming::id_type const& id); | ||
| std::pair<naming::id_type, naming::address> | ||
| begin_migration(naming::id_type const& id); | ||
| bool end_migration(naming::id_type const& id); |
There was a problem hiding this comment.
These operations are potentially remote. What was your rationale to change this to run synchronously?
There was a problem hiding this comment.
The main rationale was that those two functions were always executed on the components service locality. Remote execution never happened in the migration implementation we have.
- Simplified migration handling in primary namespace - Fixing various race conditions
sithhell
force-pushed
the
fix_migration
branch
from
b2a2120
to
c56b0fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.