Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aspellWithDicts: don't --set ASPELL_CONFIG but use --add-flags #34856

Closed
wants to merge 1 commit into from
Closed

aspellWithDicts: don't --set ASPELL_CONFIG but use --add-flags #34856

wants to merge 1 commit into from

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Feb 11, 2018

Setting ASPELL_CONF blocks the user from using a aspell.conf file.
Flags on the other hand can still be overridden.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
aspellWithDicts: don't --set ASPELL_CONFIG but use --add-flags
8ea665d 
Setting `ASPELL_CONF` blocks the user from using a aspell.conf file.
Flags on the other hand can still be overridden.
@FRidh
Copy link
Member Author

FRidh commented Feb 11, 2018

I actually think it is better to have --prefix=$out instead. Note that requires changing the aspell patch.

@FRidh FRidh mentioned this pull request Feb 11, 2018
Merged
6 tasks
@FRidh FRidh mentioned this pull request Apr 3, 2018
Closed
@mmahut
Copy link
Member

mmahut commented Aug 3, 2019

What is the status of this pull request?

@FRidh
Copy link
Member Author

FRidh commented Aug 3, 2019

Haven't used aspell in a long time and not sure what is needed anymore.

@FRidh FRidh closed this Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: enhancement 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FRidh @mmahut @GrahamcOfBorg