Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acpica-tools: init at 20180209 #34883

Merged
merged 2 commits into from Feb 15, 2018
Merged

acpica-tools: init at 20180209 #34883

merged 2 commits into from Feb 15, 2018

Conversation

tadfisher
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

joachifm
joachifm reviewed Feb 13, 2018
View reviewed changes
pkgs/tools/system/acpica-tools/default.nix Outdated

enableParallelBuilding = true;

buildFlags = stdenv.lib.concatStringsSep " " [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not hugely important, but is concatStringsSep really necessary? I'd expect it to end up being exported into the builder environment as a space separated string anyways.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right, and the Nixpkgs manual needs some clarification.

pkgs/tools/system/acpica-tools/default.nix Outdated
"acpixtract"
];

buildInputs = [ bison flex ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these can be treated as nativeBuildInputs, if they are used only for codegen during the build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build acpica-tools

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘acpica-tools-20180209’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/tools/system/acpica-tools/default.nix:30 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/9vpxn1q54hmfrqqavivx58l9dpmyx119-acpica-tools-20180209/bin/acpinames
shrinking /nix/store/9vpxn1q54hmfrqqavivx58l9dpmyx119-acpica-tools-20180209/bin/acpihelp
shrinking /nix/store/9vpxn1q54hmfrqqavivx58l9dpmyx119-acpica-tools-20180209/bin/acpiexec
shrinking /nix/store/9vpxn1q54hmfrqqavivx58l9dpmyx119-acpica-tools-20180209/bin/acpidump
shrinking /nix/store/9vpxn1q54hmfrqqavivx58l9dpmyx119-acpica-tools-20180209/bin/acpibin
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/9vpxn1q54hmfrqqavivx58l9dpmyx119-acpica-tools-20180209/bin
patching script interpreter paths in /nix/store/9vpxn1q54hmfrqqavivx58l9dpmyx119-acpica-tools-20180209
checking for references to /build in /nix/store/9vpxn1q54hmfrqqavivx58l9dpmyx119-acpica-tools-20180209...
/nix/store/9vpxn1q54hmfrqqavivx58l9dpmyx119-acpica-tools-20180209

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/pvb41c3xi8ngdsyb9vfw268vrdpr67wz-acpica-tools-20180209/bin/acpihelp
shrinking /nix/store/pvb41c3xi8ngdsyb9vfw268vrdpr67wz-acpica-tools-20180209/bin/acpinames
shrinking /nix/store/pvb41c3xi8ngdsyb9vfw268vrdpr67wz-acpica-tools-20180209/bin/acpidump
shrinking /nix/store/pvb41c3xi8ngdsyb9vfw268vrdpr67wz-acpica-tools-20180209/bin/acpibin
shrinking /nix/store/pvb41c3xi8ngdsyb9vfw268vrdpr67wz-acpica-tools-20180209/bin/acpixtract
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/pvb41c3xi8ngdsyb9vfw268vrdpr67wz-acpica-tools-20180209/bin 
patching script interpreter paths in /nix/store/pvb41c3xi8ngdsyb9vfw268vrdpr67wz-acpica-tools-20180209
checking for references to /tmp/nix-build-acpica-tools-20180209.drv-0 in /nix/store/pvb41c3xi8ngdsyb9vfw268vrdpr67wz-acpica-tools-20180209...
/nix/store/pvb41c3xi8ngdsyb9vfw268vrdpr67wz-acpica-tools-20180209

@joachifm joachifm merged commit 9b7467e into NixOS:master Feb 15, 2018
@joachifm
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tadfisher @joachifm @GrahamcOfBorg