Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fwts: init at 18.01.00 #34877

Merged
merged 1 commit into from Mar 4, 2018
Merged

fwts: init at 18.01.00 #34877

merged 1 commit into from Mar 4, 2018

Conversation

tadfisher
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build fwts

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘fwts-18.01.00’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/fwts/default.nix:25 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/f1nil4dwf4ycgwhylx67id1c1pwz116f-fwts-18.01.00/bin/fwts
shrinking /nix/store/f1nil4dwf4ycgwhylx67id1c1pwz116f-fwts-18.01.00/lib/fwts/libfwts.so.1.0.0
shrinking /nix/store/f1nil4dwf4ycgwhylx67id1c1pwz116f-fwts-18.01.00/lib/fwts/libfwtsacpica.so.1.0.0
shrinking /nix/store/f1nil4dwf4ycgwhylx67id1c1pwz116f-fwts-18.01.00/lib/fwts/libfwtsiasl.so.1.0.0
gzipping man pages under /nix/store/f1nil4dwf4ycgwhylx67id1c1pwz116f-fwts-18.01.00/share/man/
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/f1nil4dwf4ycgwhylx67id1c1pwz116f-fwts-18.01.00/lib  /nix/store/f1nil4dwf4ycgwhylx67id1c1pwz116f-fwts-18.01.00/bin 
patching script interpreter paths in /nix/store/f1nil4dwf4ycgwhylx67id1c1pwz116f-fwts-18.01.00
checking for references to /tmp/nix-build-fwts-18.01.00.drv-0 in /nix/store/f1nil4dwf4ycgwhylx67id1c1pwz116f-fwts-18.01.00...
/nix/store/f1nil4dwf4ycgwhylx67id1c1pwz116f-fwts-18.01.00

joachifm
joachifm reviewed Feb 13, 2018
View reviewed changes
pkgs/os-specific/linux/fwts/default.nix Outdated
version = "18.01.00";

src = fetchzip {
url = "http://fwts.ubuntu.com/release/fwts-V18.01.00.tar.gz";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider reusing version here, to simplify bumps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/0npz92m3app4iznibf7ax1mvdsni5i1v-fwts-18.01.00/bin/fwts
shrinking /nix/store/0npz92m3app4iznibf7ax1mvdsni5i1v-fwts-18.01.00/lib/fwts/libfwtsacpica.so.1.0.0
shrinking /nix/store/0npz92m3app4iznibf7ax1mvdsni5i1v-fwts-18.01.00/lib/fwts/libfwts.so.1.0.0
shrinking /nix/store/0npz92m3app4iznibf7ax1mvdsni5i1v-fwts-18.01.00/lib/fwts/libfwtsiasl.so.1.0.0
gzipping man pages under /nix/store/0npz92m3app4iznibf7ax1mvdsni5i1v-fwts-18.01.00/share/man/
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/0npz92m3app4iznibf7ax1mvdsni5i1v-fwts-18.01.00/lib  /nix/store/0npz92m3app4iznibf7ax1mvdsni5i1v-fwts-18.01.00/bin
patching script interpreter paths in /nix/store/0npz92m3app4iznibf7ax1mvdsni5i1v-fwts-18.01.00
checking for references to /build in /nix/store/0npz92m3app4iznibf7ax1mvdsni5i1v-fwts-18.01.00...
/nix/store/0npz92m3app4iznibf7ax1mvdsni5i1v-fwts-18.01.00

@joachifm
Copy link
Contributor

Needs a rebase

@tadfisher
Copy link
Contributor Author

@joachifm Rebased, thanks.

@joachifm joachifm merged commit 5bbb20f into NixOS:master Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tadfisher @joachifm @GrahamcOfBorg