massren: init at 1.5.4 #34880
Closed
massren: init at 1.5.4 #34880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornfor
reviewed
Feb 12, 2018
pkgs/tools/misc/massren/default.nix
Outdated
| @@ -0,0 +1,22 @@ | |||
| { stdenv, buildGoPackage, fetchFromGitHub, pkgs }: | |||
There was a problem hiding this comment.
Please remove the 'pkgs' argument. (It's both unused and not recommended to take it as argument -- better be explicit about dependencies.)
There was a problem hiding this comment.
@bjornfor - Fixed and force-pushed!
andrew-d
force-pushed
the
adunham/massren
branch
from
0e78159
to
b5c8eb8
Compare
|
Applied to master (5043217). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
massren is a pretty helpful tool for editing a bunch of files all at once in your editor, and I use it ~every day. I figured I'd try upstreaming the package!
Things done
build-use-sandboxinnix.confon non-NixOS)Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)Tested compilation of all pkgs that depend on this change usingnix-shell -p nox --run "nox-review wip"./result/bin/)