Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use static cabal2nix in callCabal2nix #34863

Merged

Conversation

ElvishJerricco
Copy link
Contributor

Motivation for this change

Currently, using callCabal2nix requires all the build-time dependencies of cabal2nix. pkgs.cabal2nix uses justStaticExecutables. So if it is cached, then you only need to download these executables, not all the unnecessary library dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ElvishJerricco
Copy link
Contributor Author

@Ericson2314 This is a sane change, in terms of cross, right?

@Ericson2314
Copy link
Member

Yup!

@Ericson2314 Ericson2314 merged commit 6acfa35 into NixOS:master Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants