Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpp-gsl: treat sign-conversion as warning #36630

Merged
merged 3 commits into from Mar 12, 2018
Merged

cpp-gsl: treat sign-conversion as warning #36630

merged 3 commits into from Mar 12, 2018

Conversation

yuriaisaka
Copy link
Contributor

@yuriaisaka yuriaisaka commented Mar 9, 2018 •
edited

Motivation for this change

Fixes hydra build failure https://hydra.nixos.org/build/69860422 of upstream tests by treating C++ sign-conversion as warning. (Presumably, the update of the default gcc from gcc6 to gcc7 have instroduced -Werror=sign-conversion to the default compiler options.)

Also, takes this opportunity to update to a recent version.

edit: /cc ZHF #36453

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@yuriaisaka yuriaisaka changed the title Pr cpp gsl update PR: cpp-gsl update Mar 9, 2018
@yuriaisaka yuriaisaka changed the title PR: cpp-gsl update cpp-gsl: unstable-2017-02-15 -> unstable-03-06 Mar 9, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 9, 2018

@GrahamcOfBorg build cpp-gsl

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

-- Installing: /nix/store/9pr7sgypyhglxl497ssssbh6za6zymm2-GSL-unstable-2018-03-06/include/gsl/gsl_byte
-- Installing: /nix/store/9pr7sgypyhglxl497ssssbh6za6zymm2-GSL-unstable-2018-03-06/include/gsl/gsl_util
-- Installing: /nix/store/9pr7sgypyhglxl497ssssbh6za6zymm2-GSL-unstable-2018-03-06/include/gsl/multi_span
-- Installing: /nix/store/9pr7sgypyhglxl497ssssbh6za6zymm2-GSL-unstable-2018-03-06/include/gsl/pointers
-- Installing: /nix/store/9pr7sgypyhglxl497ssssbh6za6zymm2-GSL-unstable-2018-03-06/include/gsl/span
-- Installing: /nix/store/9pr7sgypyhglxl497ssssbh6za6zymm2-GSL-unstable-2018-03-06/include/gsl/string_span
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/9pr7sgypyhglxl497ssssbh6za6zymm2-GSL-unstable-2018-03-06
/nix/store/9pr7sgypyhglxl497ssssbh6za6zymm2-GSL-unstable-2018-03-06

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

-- Installing: /nix/store/1h8qyys4fgsc2ymzi01k1i2691agmi3w-GSL-unstable-2018-03-06/include/gsl/gsl_byte
-- Installing: /nix/store/1h8qyys4fgsc2ymzi01k1i2691agmi3w-GSL-unstable-2018-03-06/include/gsl/gsl_assert
-- Installing: /nix/store/1h8qyys4fgsc2ymzi01k1i2691agmi3w-GSL-unstable-2018-03-06/include/gsl/gsl_algorithm
-- Installing: /nix/store/1h8qyys4fgsc2ymzi01k1i2691agmi3w-GSL-unstable-2018-03-06/include/gsl/gsl
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1h8qyys4fgsc2ymzi01k1i2691agmi3w-GSL-unstable-2018-03-06
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/1h8qyys4fgsc2ymzi01k1i2691agmi3w-GSL-unstable-2018-03-06
checking for references to /build in /nix/store/1h8qyys4fgsc2ymzi01k1i2691agmi3w-GSL-unstable-2018-03-06...
/nix/store/1h8qyys4fgsc2ymzi01k1i2691agmi3w-GSL-unstable-2018-03-06

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

-- Installing: /nix/store/fnrpb8s2mszrr0myi9bv230g1w2i6cgk-GSL-unstable-2018-03-06/include/gsl/string_span
-- Installing: /nix/store/fnrpb8s2mszrr0myi9bv230g1w2i6cgk-GSL-unstable-2018-03-06/include/gsl/gsl_algorithm
-- Installing: /nix/store/fnrpb8s2mszrr0myi9bv230g1w2i6cgk-GSL-unstable-2018-03-06/include/gsl/gsl
-- Installing: /nix/store/fnrpb8s2mszrr0myi9bv230g1w2i6cgk-GSL-unstable-2018-03-06/include/gsl/pointers
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fnrpb8s2mszrr0myi9bv230g1w2i6cgk-GSL-unstable-2018-03-06
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/fnrpb8s2mszrr0myi9bv230g1w2i6cgk-GSL-unstable-2018-03-06
checking for references to /tmp/nix-build-GSL-unstable-2018-03-06.drv-0 in /nix/store/fnrpb8s2mszrr0myi9bv230g1w2i6cgk-GSL-unstable-2018-03-06...
/nix/store/fnrpb8s2mszrr0myi9bv230g1w2i6cgk-GSL-unstable-2018-03-06

fpletz
fpletz reviewed Mar 12, 2018
View reviewed changes
pkgs/development/libraries/cpp-gsl/default.nix Outdated
@@ -2,7 +2,7 @@

stdenv.mkDerivation rec {
pname = "GSL-unstable";
version = "2017-02-15";
version = "2018-03-06";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did not update the git revision, so bumping the date is not necessary.

@fpletz fpletz changed the title cpp-gsl: unstable-2017-02-15 -> unstable-03-06 cpp-gsl: treat sign-conversion as warning Mar 12, 2018
@fpletz fpletz merged commit 77e2f28 into NixOS:master Mar 12, 2018
fpletz pushed a commit that referenced this pull request Mar 12, 2018
@yuriaisaka @fpletz
cpp-gsl: treat sign-conversion as warning (#36630)
050ad5d 
(cherry picked from commit 77e2f28)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yuriaisaka @Mic92 @GrahamcOfBorg @fpletz