Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgroove: fix build #36626

Merged
merged 1 commit into from Mar 12, 2018
Merged

libgroove: fix build #36626

merged 1 commit into from Mar 12, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 9, 2018 •
edited

Motivation for this change

When compiling with GCC v7 and the -Werror flag several new warnings
caused the build to fail: https://hydra.nixos.org/build/70751457/nixlog/2

Note: I patched the CMake file manually as v4.3.0 is quite old, a v5 is
in progress, but isn't stable yet, so patching v4 seems to be the better
solution taking stability into account.

See tickets #31747 and #36453

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27
libgroove: fix build
f3809c6 
When compiling with GCC v7 and the `-Werror` flag several new warnings
caused the build to fail: https://hydra.nixos.org/build/70751457/nixlog/2

Note: I patched the CMake file manually as v4.3.0 is quite old, a v5 is
in progress, but isn't stable yet, so patching v4 seems to be the better
solution taking stability into account.

See tickets NixOS#31747 and NixOS#36453
@Ma27
Copy link
Member Author

Ma27 commented Mar 9, 2018 •
edited

currently running nox-review

EDIT: everything's fine, see the original comment

@vcunat
Copy link
Member

vcunat commented Mar 12, 2018

@GrahamcOfBorg build libgroove

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin

The following builds were skipped because they don't evaluate on x86_64-darwin: libgroove

No log is available.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libgroove

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/nl00rvywvmg5b4i9a6w4q8nqs3r7v4jw-libgroove-4.3.0
shrinking /nix/store/nl00rvywvmg5b4i9a6w4q8nqs3r7v4jw-libgroove-4.3.0/lib/libgrooveloudness.so.4.3.0
shrinking /nix/store/nl00rvywvmg5b4i9a6w4q8nqs3r7v4jw-libgroove-4.3.0/lib/libgrooveplayer.so.4.3.0
shrinking /nix/store/nl00rvywvmg5b4i9a6w4q8nqs3r7v4jw-libgroove-4.3.0/lib/libgroovefingerprinter.so.4.3.0
shrinking /nix/store/nl00rvywvmg5b4i9a6w4q8nqs3r7v4jw-libgroove-4.3.0/lib/libgroove.so.4.3.0
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/nl00rvywvmg5b4i9a6w4q8nqs3r7v4jw-libgroove-4.3.0/lib 
patching script interpreter paths in /nix/store/nl00rvywvmg5b4i9a6w4q8nqs3r7v4jw-libgroove-4.3.0
checking for references to /tmp/nix-build-libgroove-4.3.0.drv-0 in /nix/store/nl00rvywvmg5b4i9a6w4q8nqs3r7v4jw-libgroove-4.3.0...
/nix/store/nl00rvywvmg5b4i9a6w4q8nqs3r7v4jw-libgroove-4.3.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libgroove

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/9b4myv16xfwfhp3hqff7fsyb7mswpana-libgroove-4.3.0
shrinking /nix/store/9b4myv16xfwfhp3hqff7fsyb7mswpana-libgroove-4.3.0/lib/libgroovefingerprinter.so.4.3.0
shrinking /nix/store/9b4myv16xfwfhp3hqff7fsyb7mswpana-libgroove-4.3.0/lib/libgrooveloudness.so.4.3.0
shrinking /nix/store/9b4myv16xfwfhp3hqff7fsyb7mswpana-libgroove-4.3.0/lib/libgrooveplayer.so.4.3.0
shrinking /nix/store/9b4myv16xfwfhp3hqff7fsyb7mswpana-libgroove-4.3.0/lib/libgroove.so.4.3.0
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/9b4myv16xfwfhp3hqff7fsyb7mswpana-libgroove-4.3.0/lib
patching script interpreter paths in /nix/store/9b4myv16xfwfhp3hqff7fsyb7mswpana-libgroove-4.3.0
checking for references to /build in /nix/store/9b4myv16xfwfhp3hqff7fsyb7mswpana-libgroove-4.3.0...
/nix/store/9b4myv16xfwfhp3hqff7fsyb7mswpana-libgroove-4.3.0

vcunat added a commit to vcunat/nixpkgs that referenced this pull request Mar 12, 2018
@vcunat
Merge NixOS#36626: libgroove: fix build
8a74c75
vcunat added a commit that referenced this pull request Mar 12, 2018
@vcunat
Merge #36626: libgroove: fix build
bb88585 
(cherry picked from commit 8a74c75)
@vcunat vcunat merged commit f3809c6 into NixOS:master Mar 12, 2018
@Ma27 Ma27 deleted the fix-libgroove branch March 12, 2018 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @vcunat @GrahamcOfBorg