Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamviewer: 12.0.85001 -> 12.0.90041 #36673

Merged
merged 1 commit into from Mar 13, 2018
Merged

teamviewer: 12.0.85001 -> 12.0.90041 #36673

merged 1 commit into from Mar 13, 2018

Conversation

averelld
Copy link
Contributor

@averelld averelld commented Mar 9, 2018

Motivation for this change

Old URL is a dead link.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@unode
Copy link
Member

unode commented Mar 10, 2018

Does this version works for you? I just applied the patch locally and it seems the client can't contact the daemon.
It always displays the "launch daemon as root" message. I have teamviewer.enable = true and the teamviewerd service is running.

@unode
Copy link
Member

unode commented Mar 10, 2018

Ok I take that back. Seems like the local ~/.local/share/teamviewer* installation isn't compatible with the previous version. One has to remove this location to have the new teamviewer version work as expected.

@cx405
Copy link

cx405 commented Mar 13, 2018

Please push it into stable (17.09) as well for the same reason.

Perhaps we should create another channel for expressions that rely on such volatile, changing URLs.

@fpletz fpletz merged commit 6e55d83 into NixOS:master Mar 13, 2018
@averelld averelld deleted the upgrade-teamviewer branch March 13, 2018 22:19
@cx405 cx405 mentioned this pull request Mar 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@averelld @unode @cx405 @fpletz @GrahamcOfBorg