Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idrisPackages: fix errors #36619

Merged
merged 2 commits into from Mar 9, 2018
Merged

idrisPackages: fix errors #36619

merged 2 commits into from Mar 9, 2018

Conversation

brainrake
Copy link
Contributor

@brainrake brainrake commented Mar 9, 2018 •
edited

Motivation for this change
  • idrisPackages attrset could not be evaluated because of missing optparse
  • idrisPackages.wl-pprint package definition was broken, preventing idrisPackages from being evaluated
  • idrisPackages.wl-pprint was out of date and didn't build

I've successfully built all Idris packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Mar 9, 2018

@GrahamcOfBorg build idrisPackages.wl-pprint

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘jailbreak-cabal-1.3.2’ in /var/lib/gc-of-borg/nix-test-rs-16/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-16/pkgs/development/haskell-modules/hackage-packages.nix:120719 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)


./Text/PrettyPrint/Leijen/Test.idr:28:3-35:
   |
28 |   listContents car Nil = pprint car
   |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Text.PrettyPrint.Leijen.Test.listContents is possibly not total due to: Text.PrettyPrint.Leijen.Test.pprint

./Text/PrettyPrint/Leijen.idr:167:9-61:Could not build: Text.PrettyPrint.Leijen.group, flatten is possibly not total due to recursive path Text.PrettyPrint.Leijen.group, flatten --> Text.PrettyPrint.Leijen.group, flatten --> Text.PrettyPrint.Leijen.group, flatten
builder for ‘/nix/store/4dqsslikvsh2aisza4wk66zqxz4qfx6z-wl-pprint-2016-09-28.drv’ failed with exit code 1
error: build of ‘/nix/store/4dqsslikvsh2aisza4wk66zqxz4qfx6z-wl-pprint-2016-09-28.drv’ failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)


./Text/PrettyPrint/Leijen/Test.idr:28:3-35:
   |
28 |   listContents car Nil = pprint car
   |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Text.PrettyPrint.Leijen.Test.listContents is possibly not total due to: Text.PrettyPrint.Leijen.Test.pprint

./Text/PrettyPrint/Leijen.idr:167:9-61:Could not build: Text.PrettyPrint.Leijen.group, flatten is possibly not total due to recursive path Text.PrettyPrint.Leijen.group, flatten --> Text.PrettyPrint.Leijen.group, flatten --> Text.PrettyPrint.Leijen.group, flatten
builder for '/nix/store/73xzfsw253s8y5zcbl0xl6flyv9k9wyj-wl-pprint-2016-09-28.drv' failed with exit code 1
error: build of '/nix/store/73xzfsw253s8y5zcbl0xl6flyv9k9wyj-wl-pprint-2016-09-28.drv' failed

@Mic92
Copy link
Member

Mic92 commented Mar 9, 2018

@GrahamcOfBorg build idrisPackages.wl-pprint

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘jailbreak-cabal-1.3.2’ in /var/lib/gc-of-borg/nix-test-rs-21/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-21/pkgs/development/haskell-modules/hackage-packages.nix:120719 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

Installing Text/PrettyPrint/Leijen.ibc to /nix/store/7vlzfzcbhgn9h35bxggjl68mm06q7x8n-wl-pprint-2017-03-13/libs/wlpprint/Text/PrettyPrint
Installing Text/PrettyPrint/Leijen/Class.ibc to /nix/store/7vlzfzcbhgn9h35bxggjl68mm06q7x8n-wl-pprint-2017-03-13/libs/wlpprint/Text/PrettyPrint/Leijen
Installing Text/PrettyPrint/Leijen/Test.ibc to /nix/store/7vlzfzcbhgn9h35bxggjl68mm06q7x8n-wl-pprint-2017-03-13/libs/wlpprint/Text/PrettyPrint/Leijen
Installing 00wlpprint-idx.ibc to /nix/store/7vlzfzcbhgn9h35bxggjl68mm06q7x8n-wl-pprint-2017-03-13/libs/wlpprint
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7vlzfzcbhgn9h35bxggjl68mm06q7x8n-wl-pprint-2017-03-13
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/7vlzfzcbhgn9h35bxggjl68mm06q7x8n-wl-pprint-2017-03-13
checking for references to /tmp/nix-build-wl-pprint-2017-03-13.drv-0 in /nix/store/7vlzfzcbhgn9h35bxggjl68mm06q7x8n-wl-pprint-2017-03-13...
/nix/store/7vlzfzcbhgn9h35bxggjl68mm06q7x8n-wl-pprint-2017-03-13

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

Type checking ./Text/PrettyPrint/Leijen/Test.idr
installing
Installing Text/PrettyPrint/Leijen.ibc to /nix/store/9hss5yqzxqgzd3qr5jipmjq87z6injsi-wl-pprint-2017-03-13/libs/wlpprint/Text/PrettyPrint
Installing Text/PrettyPrint/Leijen/Class.ibc to /nix/store/9hss5yqzxqgzd3qr5jipmjq87z6injsi-wl-pprint-2017-03-13/libs/wlpprint/Text/PrettyPrint/Leijen
Installing Text/PrettyPrint/Leijen/Test.ibc to /nix/store/9hss5yqzxqgzd3qr5jipmjq87z6injsi-wl-pprint-2017-03-13/libs/wlpprint/Text/PrettyPrint/Leijen
Installing 00wlpprint-idx.ibc to /nix/store/9hss5yqzxqgzd3qr5jipmjq87z6injsi-wl-pprint-2017-03-13/libs/wlpprint
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/9hss5yqzxqgzd3qr5jipmjq87z6injsi-wl-pprint-2017-03-13
/nix/store/9hss5yqzxqgzd3qr5jipmjq87z6injsi-wl-pprint-2017-03-13

@Mic92 Mic92 merged commit 2d2208e into NixOS:master Mar 9, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 9, 2018

also backported.

@brainrake brainrake deleted the fix-idrisPackages branch March 16, 2018 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brainrake @Mic92 @GrahamcOfBorg